Implement QuickValues over time widget #4244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses the same logic we use in the web interface to construct an interval.
This is nowhere near a generic component at the moment.
We will reuse this soon.
Adding this in #4205 was a mistake. The fields need to be in a separate file.
Otherwise we would overwrite the x axis label.
We have been passing this.CHART_MARGINS into the chart and dc.js was modifying the values. So on every new chart render the chart got smaller. Use an immutable value for this.CHART_MARGINS.
Wrap terms query with stacked fields in an additional filter to ensure that the main and stacked fields actually exist in the message. Otherwise we would get "null" values in the result.
Removing unused variables and simplify some code.
ghost
assigned 
|
The Top-2 value is actually the most common term here, so somewhere the ordering goes wrong. |
|
There are a couple of improvements we can do, but in the interest of getting broader feedback we'll postpone those and talk about them in subsequent PRs. Rest lgtm! |
kroepke
approved these changes
Oct 16, 2017
kroepke
pushed a commit
that referenced
this pull request
Oct 16, 2017
* Extract histogram boundary parsing into tools * First stab at terms histogram API endpoints * Add /terms-histogram endpoint for absolute and keyword searches * Make interval optional and build a sane default based on the timerange This uses the same logic we use in the web interface to construct an interval. * Initial QuickValues over time visualization * Make sure the chart container is using the complete width * Add link to go back from histogram to the overview * Disable animations * Rename StackedChartVisualization to QuickValuesHistogramVisualization This is nowhere near a generic component at the moment. * Move some code from SearchResource into a helper so we can reuse it * Move some code from QuickvaluesWidgetStrategy into base class We will reuse this soon. * Add QUICKVALUES_HISTOGRAM widget strategy * Make it possible to add the quickvalues histogram to dashboards * Move quick values config out of QueryConfiguration Adding this in #4205 was a mistake. The fields need to be in a separate file. * Only show data table limit if not qv histogram * Remove unused "show_chart_legend" * Restrict the chart legend to max 5 entries Otherwise we would overwrite the x axis label. * Improve QV histogram rendering based on GraphVisualization * Handle resizing issues * Fix chart size issue where the chart gets smaller every new render We have been passing this.CHART_MARGINS into the chart and dc.js was modifying the values. So on every new chart render the chart got smaller. Use an immutable value for this.CHART_MARGINS. * Account for y label in margin * Fix terms/termsHistogram bug with stacked fields Wrap terms query with stacked fields in an additional filter to ensure that the main and stacked fields actually exist in the message. Otherwise we would get "null" values in the result. * Cleanup QuickValuesHistogramVisualization Removing unused variables and simplify some code. * Cleanup QuickValues configuration forms * Fix bucket sorting in quickvalue histogram (cherry picked from commit d5fd35d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a new visualization to show quick values over time as a stacked bar chart.
Refs #4082