Update Terms Method to Support Ascending and Descending Ordering #3540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
joschi
suggested changes
Feb 23, 2017
| @@ -263,11 +263,19 @@ public SearchResult search(SearchesConfig config) { | |||
| return new SearchResult(r.getHits(), indices, config.query(), request.source(), r.getTook()); | |||
| } | |||
|
|
|||
| public TermsResult terms(String field, int size, String query, String filter, TimeRange range) { | |||
| public TermsResult terms(String field, int size, String query, String filter, TimeRange range, String sorting) { | |||
There was a problem hiding this comment.
Please don't use a string for sorting here but Sorting.Direction instead.
joschi
suggested changes
Feb 27, 2017
| if (size == 0) { | ||
| size = 50; | ||
| } | ||
|
|
||
| if (sorting == Sorting.Direction.DESC){ | ||
| termsOrder = Terms.Order.count(false); |
There was a problem hiding this comment.
Why not Terms.Order#term(boolean) here?
There was a problem hiding this comment.
Hi @joschi. I am using count because I am ordering based on the returned document count of the aggregation instead of the term itself.
Per the docs: https://www.elastic.co/guide/en/elasticsearch/client/java-api/2.4/_bucket_aggregations.html#_order
Ordering the buckets by their doc_count in an ascending manner:
AggregationBuilders
.terms("genders")
.field("gender")
.order(Terms.Order.count(true))
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add sort order to the terms method (org.graylog2.indexer.searches.Searches) in order to provide support for ascending and descending Terms aggregation results. Relying on widgets to conduct the ascending order does not provide a "true bottom" value, it only provides the most ascending result based on a descending pull; if the possible results are greater than the size of the pull (e.g. 50) this will result in an inaccurate and misleading result.
Description
The changes provide a sorting variable to the terms method. Subsequent functions for the method were modified to pass a default value of "descending" into the method in order to assure backwards compatibility. The changes passed the "testTerms" Test.
Motivation and Context
This change is required to provide true ascending, or bottom, values for term based aggregations.
Relates to Issue #2459
How Has This Been Tested?
Types of changes
Checklist: