Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update testcontainers to 1.16.0. #11325

Merged
merged 3 commits into from
Sep 23, 2021
Merged

Update testcontainers to 1.16.0. #11325

merged 3 commits into from
Sep 23, 2021

Conversation

malcyon
Copy link
Contributor

@malcyon malcyon commented Sep 22, 2021

Description

Updating the testcontainers dependency to 1.16.0.

Motivation and Context

We are seeing intermittent test failures in Jenkins like:

08:17:32 org.testcontainers.containers.ContainerLaunchException: Container startup failed

We've seen similar issues in the past, and they were resolved by updating testcontainers. This error disappeared for a long time, but now it is back. I would like to see if this resolves the issue. If we need to dig deeper, it will also help to be on the latest version.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@malcyon
Copy link
Contributor Author

malcyon commented Sep 22, 2021

Error:

08:44:47  [INFO] Running org.graylog.security.authservice.ldap.UnboundLDAPConnectorTestTLSIT
08:44:58  [ERROR] Tests run: 9, Failures: 0, Errors: 9, Skipped: 0, Time elapsed: 10.871 s <<< FAILURE! - in org.graylog.security.authservice.ldap.UnboundLDAPConnectorTestTLSIT
08:44:58  [ERROR] shouldNotConnectViaSSLToSelfSignedCertIfValidationIsRequested  Time elapsed: 0.367 s  <<< ERROR!
08:44:58  java.lang.IllegalArgumentException: Requested port (636) is not mapped
08:44:58  	at org.testcontainers.containers.ContainerState.getMappedPort(ContainerState.java:153)

@malcyon
Copy link
Contributor Author

malcyon commented Sep 22, 2021

The new version of testcontainers doesn't publish all ports by default anymore.

testcontainers/testcontainers-java#4286
testcontainers/testcontainers-java#4263

It looks like OpenLDAPContainer.java isn't setting .withExposedPorts. It is being correctly set in NodeContainerFactory.java and MongoDBContainer.java.

@malcyon
Copy link
Contributor Author

malcyon commented Sep 22, 2021

@bernd Any idea where I'm going wrong here?

@bernd bernd self-assigned this Sep 23, 2021
@malcyon malcyon requested a review from bernd September 23, 2021 13:50
@malcyon malcyon merged commit 1c99273 into master Sep 23, 2021
@malcyon malcyon deleted the update/testcontainers-1.16.0 branch September 23, 2021 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants