Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add "isclose" method for Vector, Box3D and LabeledBox3D #806

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: add "isclose" method for Vector, Box3D and LabeledBox3D #806

wants to merge 1 commit into from

Conversation

Lee-000
Copy link
Collaborator

@Lee-000 Lee-000 commented Jul 8, 2021

No description provided.

@Lee-000 Lee-000 requested review from AChenQ and linjiX as code owners July 8, 2021 03:49
@coveralls
Copy link

coveralls commented Jul 8, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1033504275

  • 55 of 72 (76.39%) changed or added relevant lines in 9 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.09%) to 82.637%
Changes Missing Coverage Covered Lines Changed/Added Lines %
tensorbay/geometry/transform.py 6 7 85.71%
tensorbay/geometry/vector.py 6 8 75.0%
tensorbay/utility/attr.py 24 27 88.89%
tensorbay/utility/common.py 8 19 42.11%
Totals Coverage Status
Change from base Build 1033120930: -0.09%
Covered Lines: 5183
Relevant Lines: 6272
💛 - Coveralls

@Lee-000 Lee-000 force-pushed the T16330_geometry_isclose branch from d430f9e to 5fe4fb7 Compare July 15, 2021 10:08
@Lee-000 Lee-000 marked this pull request as draft August 11, 2021 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AChenQ AChenQ Awaiting requested review from AChenQ

@linjiX linjiX Awaiting requested review from linjiX linjiX is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lee-000 @coveralls