Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(geometry): use "AttrsMixin" in "Box3D" #604

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor(geometry): use "AttrsMixin" in "Box3D" #604

wants to merge 1 commit into from

Conversation

AChenQ
Copy link
Collaborator

@AChenQ AChenQ commented May 26, 2021

No description provided.

@AChenQ AChenQ requested a review from Lee-000 as a code owner May 26, 2021 03:07
@coveralls
Copy link

coveralls commented May 26, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 892842598

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 83.195%
Totals Coverage Status
Change from base Build 892024798: 0.05%
Covered Lines: 4495
Relevant Lines: 5403
💛 - Coveralls

linjiX
linjiX requested changes May 26, 2021
View reviewed changes
tensorbay/geometry/box.py Show resolved Hide resolved
@AChenQ AChenQ force-pushed the T15548_attrs_geometry branch 2 times, most recently from 21ae816 to e909354 Compare May 26, 2021 09:23
@AChenQ AChenQ changed the title style(dataset): use "AttrsMixin" in geometry module refactor(dataset): use "AttrsMixin" in "Box3D" May 26, 2021
@AChenQ AChenQ force-pushed the T15548_attrs_geometry branch 2 times, most recently from e60dc9d to 3879c28 Compare May 26, 2021 09:42
linjiX
linjiX requested changes May 26, 2021
View reviewed changes
tensorbay/geometry/box.py Show resolved Hide resolved
@AChenQ AChenQ force-pushed the T15548_attrs_geometry branch from 3879c28 to d47b9d4 Compare May 31, 2021 12:09
@AChenQ AChenQ changed the title refactor(dataset): use "AttrsMixin" in "Box3D" refactor(geometry): use "AttrsMixin" in "Box3D" May 31, 2021
linjiX
linjiX requested changes Jun 3, 2021
View reviewed changes
tensorbay/geometry/box.py Outdated Show resolved Hide resolved
@AChenQ AChenQ force-pushed the T15548_attrs_geometry branch from d47b9d4 to e4cf8d8 Compare June 3, 2021 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linjiX linjiX linjiX requested changes

@Lee-000 Lee-000 Awaiting requested review from Lee-000

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AChenQ @coveralls @linjiX