Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(client): add "jobType" to Job.abort, Job.retry and delete_job #1239

Merged
merged 1 commit into from
Apr 6, 2022
Merged

fix(client): add "jobType" to Job.abort, Job.retry and delete_job #1239

merged 1 commit into from
Apr 6, 2022

Conversation

graczhual
Copy link
Contributor

@graczhual graczhual commented Apr 2, 2022 •
edited
Loading

No description provided.

@graczhual graczhual requested a review from AChenQ as a code owner April 2, 2022 09:21
@linjiX linjiX requested a review from Lee-000 April 2, 2022 09:22
@coveralls
Copy link

coveralls commented Apr 2, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2102930385

  • 0 of 3 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.129%
Changes Missing Coverage Covered Lines Changed/Added Lines %
tensorbay/client/version.py 0 1 0.0%
tensorbay/client/job.py 0 2 0.0%
Totals Coverage Status
Change from base Build 2102352771: 0.0%
Covered Lines: 7985
Relevant Lines: 9271
💛 - Coveralls

Lee-000
Lee-000 reviewed Apr 2, 2022
View reviewed changes
tensorbay/client/version.py Outdated Show resolved Hide resolved
@graczhual graczhual requested a review from Lee-000 April 2, 2022 10:42
@graczhual graczhual changed the title fix(client): add "job_type" to job.abort, job.retry and delete job fix(client): add "_JOB_TYPE" to class JobMixin in version.py Apr 6, 2022
@graczhual graczhual force-pushed the fix_abort_job_type branch from c7b87eb to 8126ba4 Compare April 6, 2022 04:19
@graczhual graczhual requested a review from AChenQ April 6, 2022 04:21
@graczhual graczhual force-pushed the fix_abort_job_type branch from 8126ba4 to f231767 Compare April 6, 2022 06:59
@graczhual graczhual changed the title fix(client): add "_JOB_TYPE" to class JobMixin in version.py fix(client): add "_job_type" to Job.abort, Job.retry and class JobMixin Apr 6, 2022
@graczhual graczhual changed the title fix(client): add "_job_type" to Job.abort, Job.retry and class JobMixin fix(client): add "_job_type" to Job.abort, Job.retry and delete_job Apr 6, 2022
@graczhual graczhual force-pushed the fix_abort_job_type branch 3 times, most recently from d3917f6 to eef50fc Compare April 6, 2022 07:20
@graczhual graczhual changed the title fix(client): add "_job_type" to Job.abort, Job.retry and delete_job fix(client): add "jobType" to Job.abort, Job.retry and delete_job Apr 6, 2022
@graczhual graczhual force-pushed the fix_abort_job_type branch 2 times, most recently from b734ebd to c69fffa Compare April 6, 2022 13:54
@graczhual graczhual force-pushed the fix_abort_job_type branch from c69fffa to 67ff010 Compare April 6, 2022 14:02
@graczhual graczhual merged commit 259312b into Graviti-AI:main Apr 6, 2022
@graczhual graczhual deleted the fix_abort_job_type branch April 6, 2022 14:07
linjiX pushed a commit that referenced this pull request Apr 7, 2022
@graczhual @linjiX
fix(client): add "jobType" to Job.abort, Job.retry and delete_job
b4390a0 
PR Closed: #1239
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lee-000 Lee-000 Lee-000 approved these changes

@AChenQ AChenQ Awaiting requested review from AChenQ

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@graczhual @coveralls @Lee-000 @AChenQ