Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add copyright lines for rst files #1214

Merged
merged 1 commit into from
Mar 2, 2022
Merged

docs: add copyright lines for rst files #1214

merged 1 commit into from
Mar 2, 2022

Conversation

Joey9933
Copy link
Collaborator

@Joey9933 Joey9933 commented Mar 2, 2022 •
edited
Loading

No description provided.

@Joey9933 Joey9933 requested a review from graczhual as a code owner March 2, 2022 03:55
@coveralls
Copy link

coveralls commented Mar 2, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 1920181330

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.422%
Totals Coverage Status
Change from base Build 1874459578: 0.0%
Covered Lines: 7803
Relevant Lines: 9029
💛 - Coveralls

linjiX
linjiX reviewed Mar 2, 2022
View reviewed changes
docs/source/advanced_features/cache.rst
@@ -1,3 +1,6 @@
..
Copyright 2021 Graviti. Licensed under MIT License.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need a blank line after the copyright header? @graczhual

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't found any rules or requirements. But in the format of our python files, we can leave one line blank.

@Joey9933 Joey9933 merged commit ba0c823 into Graviti-AI:main Mar 2, 2022
@Joey9933 Joey9933 deleted the T20826_license branch March 2, 2022 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graczhual graczhual graczhual approved these changes

@linjiX linjiX linjiX approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Joey9933 @coveralls @linjiX @graczhual