Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): design structure and interfaces of basicSearch #1213

Merged
merged 1 commit into from
Mar 4, 2022

Conversation

graczhual
Copy link
Contributor

@graczhual graczhual commented Feb 28, 2022

No description provided.

@graczhual graczhual requested a review from AChenQ as a code owner February 28, 2022 09:52
@graczhual graczhual force-pushed the T21416_basic_search_design branch 3 times, most recently from 1bd41d3 to d875211 Compare March 1, 2022 02:51
@coveralls
Copy link

coveralls commented Mar 1, 2022

Pull Request Test Coverage Report for Build 1926617980

  • 41 of 46 (89.13%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 86.423%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tensorbay/client/dataset.py 4 5 80.0%
tensorbay/client/search.py 20 22 90.91%
tensorbay/client/version.py 9 11 81.82%
Totals Coverage Status
Change from base Build 1921469042: 0.002%
Covered Lines: 7836
Relevant Lines: 9067

💛 - Coveralls

@linjiX linjiX requested review from Lee-000 March 3, 2022 03:13
@graczhual graczhual force-pushed the T21416_basic_search_design branch 2 times, most recently from eea879c to d9f0b8a Compare March 3, 2022 03:26
tensorbay/client/job.py Outdated Show resolved Hide resolved
tensorbay/client/version.py Outdated Show resolved Hide resolved
tensorbay/client/version.py Outdated Show resolved Hide resolved
tensorbay/client/search.py Show resolved Hide resolved
@graczhual graczhual force-pushed the T21416_basic_search_design branch from d9f0b8a to df4e625 Compare March 3, 2022 07:06
@graczhual graczhual force-pushed the T21416_basic_search_design branch from df4e625 to b91628d Compare March 4, 2022 07:02
@graczhual graczhual merged commit 3a04358 into Graviti-AI:main Mar 4, 2022
@graczhual graczhual deleted the T21416_basic_search_design branch March 4, 2022 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants