fix(client): fix AttributeError of result property of SquashAndMergeJob #1183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1618733167
💛 - Coveralls |
linjiX
requested changes
Dec 24, 2021
graczhual
force-pushed
the
add_draft_getter
branch
4 times, most recently
from
ede35f3 to
b0d14a8
Compare
linjiX
requested changes
Dec 24, 2021
| The loaded :class:`SquashAndMergeJob` object. | ||
|
|
||
| """ | ||
| job = super().from_response_body( |
There was a problem hiding this comment.
the type of job is Job not SquashAndMergeJob??
There was a problem hiding this comment.
The return type of this function in Job is the type of input cls.
AChenQ
approved these changes
Dec 24, 2021
linjiX
approved these changes
Dec 24, 2021
graczhual
force-pushed
the
add_draft_getter
branch
from
b0d14a8 to
7fe5b6d
Compare
linjiX
pushed a commit
that referenced
this pull request
Dec 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.