Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(client): use AttrMixin to handle the default values for Job attrs #1182

Merged
merged 1 commit into from
Dec 24, 2021
Merged

feat(client): use AttrMixin to handle the default values for Job attrs #1182

merged 1 commit into from
Dec 24, 2021

Conversation

graczhual
Copy link
Contributor

@graczhual graczhual commented Dec 24, 2021 •
edited
Loading

No description provided.

@graczhual graczhual requested a review from AChenQ as a code owner December 24, 2021 03:14
@graczhual graczhual requested a review from linjiX December 24, 2021 03:15
@coveralls
Copy link

coveralls commented Dec 24, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1618324095

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 85.86%
Files with Coverage Reduction New Missed Lines %
tensorbay/client/version.py 1 38.98%
Totals Coverage Status
Change from base Build 1615440555: 0.0%
Covered Lines: 7669
Relevant Lines: 8932
💛 - Coveralls

@graczhual graczhual changed the title feat(client): add default value of some attrs of Job feat(client): use AttrMixin to handle the default values for Job attrs Dec 24, 2021
@graczhual graczhual requested a review from linjiX December 24, 2021 06:27
@graczhual graczhual merged commit 7093993 into Graviti-AI:main Dec 24, 2021
@graczhual graczhual deleted the add_default_attrs branch December 24, 2021 06:33
linjiX pushed a commit that referenced this pull request Dec 24, 2021
@graczhual @linjiX
feat(client): use AttrMixin to handle the default values for Job attrs
cfe8848 
PR Closed: #1182
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AChenQ AChenQ AChenQ approved these changes

@linjiX linjiX linjiX approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@graczhual @coveralls @linjiX @AChenQ