Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(client): fix InvalidParamsValue error of jobType in generate_jobs #1181

Merged
merged 1 commit into from
Dec 23, 2021
Merged

fix(client): fix InvalidParamsValue error of jobType in generate_jobs #1181

merged 1 commit into from
Dec 23, 2021

Conversation

graczhual
Copy link
Contributor

@graczhual graczhual commented Dec 23, 2021 •
edited
Loading

No description provided.

@graczhual graczhual requested a review from AChenQ as a code owner December 23, 2021 09:13
@coveralls
Copy link

coveralls commented Dec 23, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1615318330

  • 1 of 3 (33.33%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 85.86%
Changes Missing Coverage Covered Lines Changed/Added Lines %
tensorbay/client/version.py 1 3 33.33%
Totals Coverage Status
Change from base Build 1610466669: 0.002%
Covered Lines: 7669
Relevant Lines: 8932
💛 - Coveralls

linjiX
linjiX requested changes Dec 23, 2021
View reviewed changes
tensorbay/client/version.py Outdated Show resolved Hide resolved
@graczhual graczhual requested a review from linjiX December 23, 2021 09:36
@graczhual graczhual changed the title fix(client): modify wrong job_type in generate_jobs fix(client): add variable _JOB_TYPE in generate_jobs of SquashAndMerge Dec 23, 2021
@graczhual graczhual requested a review from linjiX December 23, 2021 09:58
@graczhual graczhual changed the title fix(client): add variable _JOB_TYPE in generate_jobs of SquashAndMerge fix(client): fix InvalidParamsValue error in generate_jobs Dec 23, 2021
@graczhual graczhual force-pushed the update_job_type branch 2 times, most recently from c4ef28e to cf14b2f Compare December 23, 2021 11:11
@graczhual graczhual changed the title fix(client): fix InvalidParamsValue error in generate_jobs fix(client): fix InvalidParamsValue error of jobType in generate_jobs Dec 23, 2021
@graczhual graczhual merged commit d0e2109 into Graviti-AI:main Dec 23, 2021
@graczhual graczhual deleted the update_job_type branch December 23, 2021 11:15
linjiX pushed a commit that referenced this pull request Dec 24, 2021
@graczhual @linjiX
fix(client): fix InvalidParamsValue error of jobType in generate_jobs
7d8a2f9 
PR Closed: #1181
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AChenQ AChenQ AChenQ approved these changes

@linjiX linjiX linjiX approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@graczhual @coveralls @linjiX @AChenQ