Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): adapt OpenAPI listJob #1173

Merged
merged 1 commit into from
Dec 22, 2021

Conversation

graczhual
Copy link
Contributor

@graczhual graczhual commented Dec 21, 2021

No description provided.

@graczhual graczhual requested a review from AChenQ as a code owner December 21, 2021 07:13
@coveralls
Copy link

coveralls commented Dec 21, 2021

Pull Request Test Coverage Report for Build 1609752949

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 86.017%

Files with Coverage Reduction New Missed Lines %
tensorbay/client/version.py 3 41.67%
Totals Coverage Status
Change from base Build 1606571600: -0.03%
Covered Lines: 7683
Relevant Lines: 8932

💛 - Coveralls

@@ -643,13 +643,13 @@ def _delete_job(self, job_id: str) -> None:

"""

def _generate_jobs(
def _list_jobs(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the _generate_jobs changes to _list_jobs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we do not need to get a generator. We will add the _generate job to SquashAndMerge.
SquashAndMerge.list_jobs -> SquashAndMerge._generate_jobs -> JobMixin._list_jobs

@graczhual graczhual force-pushed the T20645_list_job branch 2 times, most recently from fa93b51 to 29511b7 Compare December 21, 2021 07:20
PR Closed: Graviti-AI#1173
@graczhual graczhual merged commit b0e50bc into Graviti-AI:main Dec 22, 2021
@graczhual graczhual deleted the T20645_list_job branch December 22, 2021 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants