Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(client): use "session" instead of "urlopen" in "RemoteData.open" #1143

Merged
merged 1 commit into from
Dec 6, 2021
Merged

feat(client): use "session" instead of "urlopen" in "RemoteData.open" #1143

merged 1 commit into from
Dec 6, 2021

Conversation

AChenQ
Copy link
Collaborator

@AChenQ AChenQ commented Dec 2, 2021 •
edited
Loading

No description provided.

@AChenQ AChenQ requested a review from linjiX as a code owner December 2, 2021 11:31
@coveralls
Copy link

coveralls commented Dec 2, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1544111677

  • 72 of 115 (62.61%) changed or added relevant lines in 7 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 86.452%
Changes Missing Coverage Covered Lines Changed/Added Lines %
tensorbay/client/requests.py 5 6 83.33%
tensorbay/client/profile.py 2 5 40.0%
tensorbay/utility/file.py 7 12 58.33%
tensorbay/utility/requests.py 53 87 60.92%
Files with Coverage Reduction New Missed Lines %
tensorbay/utility/file.py 3 81.18%
Totals Coverage Status
Change from base Build 1544098637: -0.1%
Covered Lines: 7632
Relevant Lines: 8828
💛 - Coveralls

linjiX
linjiX requested changes Dec 2, 2021
View reviewed changes
tensorbay/utility/requests.py Outdated Show resolved Hide resolved
tensorbay/utility/requests.py Outdated Show resolved Hide resolved
tensorbay/utility/requests.py Outdated Show resolved Hide resolved
tensorbay/utility/requests.py Outdated Show resolved Hide resolved
tensorbay/utility/requests.py Show resolved Hide resolved
linjiX
linjiX requested changes Dec 2, 2021
View reviewed changes
tensorbay/client/requests.py Outdated Show resolved Hide resolved
@AChenQ AChenQ force-pushed the T20234_replace_urlopen branch 2 times, most recently from 299949c to add9b7c Compare December 3, 2021 07:20
@AChenQ AChenQ force-pushed the T20234_replace_urlopen branch from add9b7c to c1ee389 Compare December 6, 2021 02:28
linjiX
linjiX requested changes Dec 6, 2021
View reviewed changes
tensorbay/utility/requests.py Outdated Show resolved Hide resolved
@AChenQ AChenQ force-pushed the T20234_replace_urlopen branch from c1ee389 to 28772f0 Compare December 6, 2021 05:44
AChenQ pushed a commit to AChenQ/tensorbay-python-sdk that referenced this pull request Dec 6, 2021
feat(client): use "session" instead of "urlopen" in "RemoteData.open"
2b2862c 
PR Closed: Graviti-AI#1143
@AChenQ AChenQ force-pushed the T20234_replace_urlopen branch from 28772f0 to 2b2862c Compare December 6, 2021 10:13
@AChenQ AChenQ force-pushed the T20234_replace_urlopen branch from 2b2862c to 7f552ba Compare December 6, 2021 10:13
@AChenQ AChenQ merged commit 4a623cd into Graviti-AI:main Dec 6, 2021
@AChenQ AChenQ deleted the T20234_replace_urlopen branch December 6, 2021 10:16
linjiX pushed a commit that referenced this pull request Dec 6, 2021
@linjiX
feat(client): use "session" instead of "urlopen" in "RemoteData.open"
99a2ca9 
PR Closed: #1143
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linjiX linjiX linjiX approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AChenQ @coveralls @linjiX