Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: code cleanup #2519

Draft
wants to merge 68 commits into
base: development
Choose a base branch
from
Draft

refactor: code cleanup #2519

wants to merge 68 commits into from

Commits on Jun 9, 2024

  1. fix: make those fields final

    @brenoepics
    brenoepics committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    6bb349d View commit details
    Browse the repository at this point in the history

  2. refactor: make getGoodsLimit one liner

    @brenoepics
    brenoepics committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    da61d30 View commit details
    Browse the repository at this point in the history

  3. refactor: replace size() == 0 with isEmpty()

    @brenoepics
    brenoepics committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    ef58ab3 View commit details
    Browse the repository at this point in the history

  4. refactor: remove unnecessary toString call

    @brenoepics
    brenoepics committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    c3eafba View commit details
    Browse the repository at this point in the history

  5. refactor: remove unnecessary semicolons

    @brenoepics
    brenoepics committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    029ef82 View commit details
    Browse the repository at this point in the history

  6. refactor: unwrap redundant code block

    @brenoepics
    brenoepics committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    9fa0f2b View commit details
    Browse the repository at this point in the history

  7. refactor: this can also be final

    @brenoepics
    brenoepics committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    7d3abb0 View commit details
    Browse the repository at this point in the history

  8. refactor: replace protected with private for final class

    @brenoepics
    brenoepics committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    ca6ddfd View commit details
    Browse the repository at this point in the history

  9. refactor: replace protected with private for final class

    @brenoepics
    brenoepics committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    0161b4d View commit details
    Browse the repository at this point in the history

  10. fix: variable is assigned to itself

    @brenoepics
    brenoepics committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    427a1cf View commit details
    Browse the repository at this point in the history

  11. chore: remove unused import

    @brenoepics
    brenoepics committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    9c946e9 View commit details
    Browse the repository at this point in the history

  12. refactor: replace Collections.sort with list.sort 

    Collections.sort is just a wrapper, so it is better to use an instance method directly.
    @brenoepics
    brenoepics committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    8c35c89 View commit details
    Browse the repository at this point in the history

  13. refactor: replace lambda with method reference

    @brenoepics
    brenoepics committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    870085f View commit details
    Browse the repository at this point in the history

  14. refactor: replace lambda with method reference

    @brenoepics
    brenoepics committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    3119e0f View commit details
    Browse the repository at this point in the history

  15. refactor: simplify map operations 

    we can use computeIfAbsent here
    @brenoepics
    brenoepics committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    c7119aa View commit details
    Browse the repository at this point in the history

  16. refactor: replace statement with expression lambda

    @brenoepics
    brenoepics committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    fcd4093 View commit details
    Browse the repository at this point in the history

  17. refactor: we don't need explicit types here

    @brenoepics
    brenoepics committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    b5d0afd View commit details
    Browse the repository at this point in the history

  18. refactor: replace for loop with enhanced loop

    @brenoepics
    brenoepics committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    bb82e21 View commit details
    Browse the repository at this point in the history

  19. refactor: Integer.ParseInt is more appropriate here

    @brenoepics
    brenoepics committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    6d669bd View commit details
    Browse the repository at this point in the history

  20. refactor: Integer.ParseInt is more appropriate here

    @brenoepics
    brenoepics committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    7db8b6f View commit details
    Browse the repository at this point in the history

  21. refactor: replace switch with enhanced switch

    @brenoepics
    brenoepics committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    c9b42a6 View commit details
    Browse the repository at this point in the history

  22. refactor: fix javadoc issues

    @brenoepics
    brenoepics committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    77e2462 View commit details
    Browse the repository at this point in the history

  23. refactor: replace concatenation log with parameterized

    @brenoepics
    brenoepics committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    6e7418a View commit details
    Browse the repository at this point in the history

  24. fix: integer division in floating point

    @brenoepics
    brenoepics committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    d5ad077 View commit details
    Browse the repository at this point in the history

  25. refactor: implicit cast from double to float may be lossy

    @brenoepics
    brenoepics committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    6e3b3b2 View commit details
    Browse the repository at this point in the history

  26. perf: Call to 'asList()' with only one argument

    @brenoepics
    brenoepics committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    4f1ad7b View commit details
    Browse the repository at this point in the history

  27. perf: class initializer may be static

    @brenoepics
    brenoepics committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    e4123f4 View commit details
    Browse the repository at this point in the history

  28. perf: count > 0 can be anyMatch

    @brenoepics
    brenoepics committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    b773529 View commit details
    Browse the repository at this point in the history

  29. perf: findAny().isPresent() is cleaner here

    @brenoepics
    brenoepics committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    33d5c52 View commit details
    Browse the repository at this point in the history

  30. perf: fix redundant addAll

    @brenoepics
    brenoepics committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    1424405 View commit details
    Browse the repository at this point in the history

  31. perf: we can chain append here

    @brenoepics
    brenoepics committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    1e2ccc9 View commit details
    Browse the repository at this point in the history

  32. perf: equals "" can be isEmpty here

    @brenoepics
    brenoepics committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    aeadf6b View commit details
    Browse the repository at this point in the history

  33. perf: add Serial annotation here

    @brenoepics
    brenoepics committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    7ee644c View commit details
    Browse the repository at this point in the history

  34. refactor(lombok): add Getter where possible

    @brenoepics
    brenoepics committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    8f4120f View commit details
    Browse the repository at this point in the history

  35. refactor(lombok): add Setter where possible

    @brenoepics
    brenoepics committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    dd9f59f View commit details
    Browse the repository at this point in the history

  36. perf: this is just Math.min

    @brenoepics
    brenoepics committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    4b03304 View commit details
    Browse the repository at this point in the history

  37. perf: size cannot be negative

    @brenoepics
    brenoepics committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    f01da54 View commit details
    Browse the repository at this point in the history

  38. perf: simplify optional chain

    @brenoepics
    brenoepics committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    8f8a6a7 View commit details
    Browse the repository at this point in the history

  39. perf: remove redundant collection operation

    @brenoepics
    brenoepics committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    85ca877 View commit details
    Browse the repository at this point in the history

  40. perf: we can just equalsIgnoreCase

    @brenoepics
    brenoepics committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    3d00abc View commit details
    Browse the repository at this point in the history

  41. perf: stream api can be simplified here

    @brenoepics
    brenoepics committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    45bf5ed View commit details
    Browse the repository at this point in the history

  42. refactor: null check is not necessary, we have instanceof

    @brenoepics
    brenoepics committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    809009f View commit details
    Browse the repository at this point in the history

  43. chore: fix codestyle indentation

    @brenoepics
    brenoepics committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    db28038 View commit details
    Browse the repository at this point in the history

  44. refactor: number comparison

    @brenoepics
    brenoepics committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    3b68645 View commit details
    Browse the repository at this point in the history

  45. refactor: fix nullable params

    @brenoepics
    brenoepics committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    d4ce7aa View commit details
    Browse the repository at this point in the history

  46. Format code [skip actions]

    @github-actions
    github-actions[bot] committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    8c53f2b View commit details
    Browse the repository at this point in the history

  47. refactor: fix lombok

    @brenoepics
    brenoepics committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    bfc2c7c View commit details
    Browse the repository at this point in the history

  48. Format code [skip actions]

    @github-actions
    github-actions[bot] committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    2bb2da4 View commit details
    Browse the repository at this point in the history

  49. ci: bump actions

    @brenoepics
    brenoepics committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    dbb4f85 View commit details
    Browse the repository at this point in the history

  50. Merge branch 'development' of https://github.com/brenoepics/Grasscutter… 

    … into development
    @brenoepics
    brenoepics committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    c313939 View commit details
    Browse the repository at this point in the history

  51. ci: Create dependabot.yml

    @brenoepics
    brenoepics authored Jun 9, 2024
    Configuration menu
    Copy the full SHA
    1234d18 View commit details
    Browse the repository at this point in the history

  52. chore(deps): bump com.google.protobuf:protoc from 3.18.1 to 4.27.1 

    Bumps [com.google.protobuf:protoc](https://github.com/protocolbuffers/protobuf) from 3.18.1 to 4.27.1.
- [Release notes](https://github.com/protocolbuffers/protobuf/releases)
- [Changelog](https://github.com/protocolbuffers/protobuf/blob/main/protobuf_release.bzl)
- [Commits](https://github.com/protocolbuffers/protobuf/commits)

---
updated-dependencies:
- dependency-name: com.google.protobuf:protoc
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
    @dependabot
    dependabot[bot] authored Jun 9, 2024
    Configuration menu
    Copy the full SHA
    62d53f3 View commit details
    Browse the repository at this point in the history

  53. chore(deps): bump com.fasterxml.jackson:jackson-bom 

    Bumps [com.fasterxml.jackson:jackson-bom](https://github.com/FasterXML/jackson-bom) from 2.14.0 to 2.17.1.
- [Commits](FasterXML/jackson-bom@jackson-bom-2.14.0...jackson-bom-2.17.1)

---
updated-dependencies:
- dependency-name: com.fasterxml.jackson:jackson-bom
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
    @dependabot
    dependabot[bot] authored Jun 9, 2024
    Configuration menu
    Copy the full SHA
    52b7ca6 View commit details
    Browse the repository at this point in the history

  54. chore(deps): bump org.jline:jline-terminal-jna from 3.21.0 to 3.26.1 

    Bumps [org.jline:jline-terminal-jna](https://github.com/jline/jline3) from 3.21.0 to 3.26.1.
- [Release notes](https://github.com/jline/jline3/releases)
- [Changelog](https://github.com/jline/jline3/blob/master/changelog.md)
- [Commits](jline/jline3@jline-parent-3.21.0...jline-parent-3.26.1)

---
updated-dependencies:
- dependency-name: org.jline:jline-terminal-jna
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
    @dependabot
    dependabot[bot] authored Jun 9, 2024
    Configuration menu
    Copy the full SHA
    bbec09d View commit details
    Browse the repository at this point in the history

  55. chore(deps): bump org.junit.jupiter:junit-jupiter-engine 

    Bumps [org.junit.jupiter:junit-jupiter-engine](https://github.com/junit-team/junit5) from 5.8.2 to 5.10.2.
- [Release notes](https://github.com/junit-team/junit5/releases)
- [Commits](junit-team/junit5@r5.8.2...r5.10.2)

---
updated-dependencies:
- dependency-name: org.junit.jupiter:junit-jupiter-engine
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
    @dependabot
    dependabot[bot] authored Jun 9, 2024
    Configuration menu
    Copy the full SHA
    ff2aeac View commit details
    Browse the repository at this point in the history

  56. security: add secure mode and padding scheme

    @brenoepics
    brenoepics committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    63fbe66 View commit details
    Browse the repository at this point in the history

  57. Merge branch 'development' of https://github.com/brenoepics/Grasscutter… 

    … into development
    @brenoepics
    brenoepics committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    75d8ed0 View commit details
    Browse the repository at this point in the history

  58. Format code [skip actions]

    @github-actions
    github-actions[bot] committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    0736956 View commit details
    Browse the repository at this point in the history

  59. Merge pull request #1 from brenoepics/dependabot/gradle/com.google.pr… 

    …otobuf-protoc-4.27.1

chore(deps): bump com.google.protobuf:protoc from 3.18.1 to 4.27.1
    @brenoepics
    brenoepics authored Jun 9, 2024
    Configuration menu
    Copy the full SHA
    fa283d8 View commit details
    Browse the repository at this point in the history

  60. Merge pull request #2 from brenoepics/dependabot/gradle/com.fasterxml… 

    ….jackson-jackson-bom-2.17.1

chore(deps): bump com.fasterxml.jackson:jackson-bom from 2.14.0 to 2.17.1
    @brenoepics
    brenoepics authored Jun 9, 2024
    Configuration menu
    Copy the full SHA
    22c7f3c View commit details
    Browse the repository at this point in the history

  61. Merge pull request #3 from brenoepics/dependabot/gradle/org.jline-jli… 

    …ne-terminal-jna-3.26.1

chore(deps): bump org.jline:jline-terminal-jna from 3.21.0 to 3.26.1
    @brenoepics
    brenoepics authored Jun 9, 2024
    Configuration menu
    Copy the full SHA
    a05d6cd View commit details
    Browse the repository at this point in the history

  62. Merge pull request #4 from brenoepics/dependabot/gradle/org.junit.jup… 

    …iter-junit-jupiter-engine-5.10.2

chore(deps): bump org.junit.jupiter:junit-jupiter-engine from 5.8.2 to 5.10.2
    @brenoepics
    brenoepics authored Jun 9, 2024
    Configuration menu
    Copy the full SHA
    cd48328 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2024

  1. chore(deps): bump org.java-websocket:Java-WebSocket from 1.5.2 to 1.5.6 

    Bumps [org.java-websocket:Java-WebSocket](https://github.com/TooTallNate/Java-WebSocket) from 1.5.2 to 1.5.6.
- [Release notes](https://github.com/TooTallNate/Java-WebSocket/releases)
- [Changelog](https://github.com/TooTallNate/Java-WebSocket/blob/master/CHANGELOG.md)
- [Commits](TooTallNate/Java-WebSocket@v1.5.2...v1.5.6)

---
updated-dependencies:
- dependency-name: org.java-websocket:Java-WebSocket
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
    @dependabot
    dependabot[bot] authored Jun 10, 2024
    Configuration menu
    Copy the full SHA
    011549f View commit details
    Browse the repository at this point in the history

  2. chore(deps): bump ch.qos.logback:logback-core from 1.4.7 to 1.5.6 

    Bumps [ch.qos.logback:logback-core](https://github.com/qos-ch/logback) from 1.4.7 to 1.5.6.
- [Commits](qos-ch/logback@v_1.4.7...v_1.5.6)

---
updated-dependencies:
- dependency-name: ch.qos.logback:logback-core
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
    @dependabot
    dependabot[bot] authored Jun 10, 2024
    Configuration menu
    Copy the full SHA
    0819435 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #9 from brenoepics/dependabot/gradle/ch.qos.logbac… 

    …k-logback-core-1.5.6

chore(deps): bump ch.qos.logback:logback-core from 1.4.7 to 1.5.6
    @brenoepics
    brenoepics authored Jun 10, 2024
    Configuration menu
    Copy the full SHA
    a0922ff View commit details
    Browse the repository at this point in the history

  4. Merge pull request #7 from brenoepics/dependabot/gradle/org.java-webs… 

    …ocket-Java-WebSocket-1.5.6

chore(deps): bump org.java-websocket:Java-WebSocket from 1.5.2 to 1.5.6
    @brenoepics
    brenoepics authored Jun 10, 2024
    Configuration menu
    Copy the full SHA
    c77aa52 View commit details
    Browse the repository at this point in the history

  5. chore(deps): bump org.slf4j:slf4j-api from 2.0.7 to 2.0.13 

    Bumps org.slf4j:slf4j-api from 2.0.7 to 2.0.13.

---
updated-dependencies:
- dependency-name: org.slf4j:slf4j-api
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
    @dependabot
    dependabot[bot] authored Jun 10, 2024
    Configuration menu
    Copy the full SHA
    ab5824b View commit details
    Browse the repository at this point in the history

  6. Merge pull request #8 from brenoepics/dependabot/gradle/org.slf4j-slf… 

    …4j-api-2.0.13

chore(deps): bump org.slf4j:slf4j-api from 2.0.7 to 2.0.13
    @brenoepics
    brenoepics authored Jun 10, 2024
    Configuration menu
    Copy the full SHA
    0e7e165 View commit details
    Browse the repository at this point in the history