Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix triggered Monster Tide spawn; fix Tower dungeon handoff #2397

Merged
merged 3 commits into from
Oct 14, 2023

Conversation

longfruit
Copy link
Contributor

Description

  • Monster Tide spawn that depends on a trigger (like killing the first 20 mobs in Floor 1 Chamber 1 to trigger spawning the last 3) used to not trigger because its source ID was not kept, causing SceneScriptManager to fail to find its relevant triggers.
  • After succeeding a Tower challenge, handoff (to Floor 1 Chamber 2 for example) was not happening because no DungeonManager was registered to the Tower scene, causing challenge completion event to be missed.

Issues fixed by this PR

Type of changes

  • Bug fix
  • New feature
  • Enhancement
  • Documentation

Checklist:

  • My code follows the style guidelines of this project
  • My pull request is unique and no other pull requests have been opened for these changes
  • I have read the Contributing note and Code of conduct
  • I am responsible for any copyright issues with my code if it occurs in the future.

@KingRainbow44 KingRainbow44 merged commit fd75ba7 into Grasscutters:development Oct 14, 2023
2 checks passed
@longfruit longfruit deleted the abyss-fix branch November 2, 2023 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants