Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA fixes: transfer event extraction for zaps + safe indexing for token amount extraction #22

Merged
merged 3 commits into from
Apr 18, 2024

Conversation

jmulq
Copy link
Collaborator

@jmulq jmulq commented Apr 18, 2024

This PR contains:

  • Fix to the transfer event extraction for withdraw one events. Some zaps meant the criteria we used to extract the transfer was not working. This caused liquidity removals to be missed.
  • Fix the indexing of token amounts for the RemoveLiquidity6. This now ensures we are only indexing up to the amount of input tokens, and not relying on what is emitted from the event. The issue was caused by empty amounts being emitted from the event, say a Vec<BigInt> of length 5, although there are only 2 input tokens.
  • Bumped release version.

@jmulq jmulq self-assigned this Apr 18, 2024
@jmulq jmulq merged commit 120da99 into master Apr 18, 2024
@jmulq jmulq deleted the more-qa-fixes branch May 8, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant