Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support extracting java version for non-java named processes #831

Merged

Conversation

marcin-ol
Copy link
Collaborator

Related Issue

#675

Motivation and Context

Some java processes can be started from a binary that doesn't start with java. We want to support profiling them and provide full metadata including java version.

@Jongy Jongy self-requested a review July 27, 2023 07:38
Copy link
Contributor

@Jongy Jongy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Gave some comments.

gprofiler/profilers/java.py Outdated Show resolved Hide resolved
gprofiler/profilers/java.py Outdated Show resolved Hide resolved
gprofiler/profilers/java.py Outdated Show resolved Hide resolved
gprofiler/profilers/java.py Outdated Show resolved Hide resolved
gprofiler/profilers/java.py Outdated Show resolved Hide resolved
gprofiler/profilers/java.py Outdated Show resolved Hide resolved
tests/test_java.py Show resolved Hide resolved
tests/test_java.py Outdated Show resolved Hide resolved
tests/test_java.py Show resolved Hide resolved
tests/test_java.py Show resolved Hide resolved
gprofiler/profilers/java.py Outdated Show resolved Hide resolved
gprofiler/profilers/java.py Outdated Show resolved Hide resolved
Copy link
Contributor

@Jongy Jongy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done reviewing

@Jongy Jongy merged commit 526a9c4 into Granulate:master Aug 11, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants