Use process_exe() everywhere #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See comment on process_exe() - it correctly raises ZombieProcess (which is a subclass of NoSuchProcess) for zombie processes. gProfiler should treat this error as processes going down.
adi-benz
suggested changes
Jan 26, 2022
adi-benz
approved these changes
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See comment on process_exe() - it correctly raises ZombieProcess (which is a subclass
of NoSuchProcess) for zombie processes.
gProfiler should treat this error as processes going down.
These are all invocations of
Process.exe()in gProfiler.See giampaolo/psutil#2062 which solves the issue in
psutil.Motivation and Context
Currently we don't handle it as "process is down", so we get unrelated errors like
Non-java basenamed process, skipping... (disable --java-safemode to profile it anyway)withexe="", which happens because the process is a zombie, so I actually want it ignored.