Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php72, download utf8 filename #50

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

mytory
Copy link

@mytory mytory commented Sep 19, 2018

1

php 7.2 deprecated each function. And Laravel framework doesn't permit deprecated function. I've intended to use this project in my Laravel project, but the framework throw ErrorException.

ErrorException

So, I changed all each() function to foreach() control structure.

2

$book->sendBook($download_filename); this code does not pass $utf8filename parameter to sendZip function. So I added an argument(2287 line in PHPePub\Core\Epub).

Thanks.

@Daniel-KM
Copy link

@Grandt There are some fixes/improvements in other forks too. Do you think you will merge them too? Thanks.

@iooe
Copy link

iooe commented Nov 21, 2018

@Daniel-KM last activity of @Grandt was in 2016 year.
@mytory you can register your fork in packagist ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants