check that exif is installed instead of GD to use it #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -253,7 +253,7 @@ public static function getImage($book, $imageSource) { | |||
| $width = ImageSX($imageFile); | |||
| $height = ImageSY($imageFile); | |||
| } | |||
| if (self::isGdInstalled()) { | |||
| if (self::isExifInstalled()) { | |||
| @$type = exif_imagetype($imageSource); | |||
There was a problem hiding this comment.
I think you can also remove this ugly @ :)
There was a problem hiding this comment.
I leave it up to @Grandt. There may be a reason.
Grandt
added a commit
that referenced
this pull request
Mar 16, 2016
check that exif is installed instead of GD to use it
|
IIRC exif can throw some rather annoying warnings to the output, usually not a problem on HTML, but deadly for a zip file like the ePub. |
|
released 4.0.7.1 with this fix. Thanks for catching it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a call for an Exif function whereas it checks for GD.