Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visuals #60

Merged
merged 6 commits into from
Nov 30, 2023
Merged

Visuals #60

merged 6 commits into from
Nov 30, 2023

Conversation

chyalexcheng
Copy link
Contributor

  • merge branch load_all
  • use seaborn to plot statistics and show distributions

Copy link
Collaborator

@Retiefasaurus Retiefasaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good. Seaborn is a nice addition to the plotting functionality. See comment on pyproject.toml.


[tool.poetry.extras]
docs = ["Sphinx", "sphinx-autodoc-typehints", "sphinx-mdinclude", "sphinx-rtd-theme"]
dev = ["pytest", "pytest-cov", "prospector", "pyroma", "h5py"]
rnn = ["wandb", "tensorflow"]
tutorials = ["ipykernel"]
visuals = ["seaborn"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we should add pandas to visuals? It is used in ```plot_pdf`` function.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so, although pandas got installed automatically when installing seaborn.

@chyalexcheng chyalexcheng merged commit 23cd753 into main Nov 30, 2023
6 of 11 checks passed
@chyalexcheng chyalexcheng deleted the visuals branch December 9, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants