Skip to content
This repository has been archived by the owner on Jul 23, 2024. It is now read-only.

Proofreading #785

Merged
merged 19 commits into from
Jun 20, 2023
Merged

Proofreading #785

merged 19 commits into from
Jun 20, 2023

Conversation

salarua
Copy link
Contributor

@salarua salarua commented Jun 19, 2023 •
edited by tfuxu
Loading

Description

Improves and clarifies wording in various areas of the UI

Type of change

  • Bugfix (Change which fixes a issue)
  • New feature (Change which adds new functionality)
  • Enhancement (Change which slightly improves existing code)
  • Breaking change (This change will introduce incompatibility with existing functionality)

Testing

  • I have tested my changes and verified that they work as expected

How to test the changes

No information provided.

@daudix
Copy link
Member

daudix commented Jun 19, 2023

Well I don't agree with some of them, will review tomorrow, today is too late

tfuxu
tfuxu suggested changes Jun 20, 2023
View reviewed changes
Copy link
Member

@tfuxu tfuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the proofreading here looks good to me. For those with which I don't fully agree, I provided comments and change suggestions below.

data/ui/preset_row.blp Outdated Show resolved Hide resolved
data/ui/monet_theming_group.blp Outdated Show resolved Hide resolved
daudix
daudix reviewed Jun 20, 2023
View reviewed changes
data/ui/help_overlay.blp Outdated Show resolved Hide resolved
daudix
daudix reviewed Jun 20, 2023
View reviewed changes
data/ui/welcome_window.blp Outdated Show resolved Hide resolved
@daudix daudix self-requested a review June 20, 2023 16:31
daudix added 2 commits June 20, 2023 19:32
@daudix
Update shell_prefs_window.blp
8c53122 
Signed-off-by: David Lapshin <[email protected]>
@daudix
Update welcome_window.blp
01539ab 
Signed-off-by: David Lapshin <[email protected]>
@tfuxu
Copy link
Member

tfuxu commented Jun 20, 2023

Can we merge?

@daudix
Copy link
Member

daudix commented Jun 20, 2023 •
edited
Loading

I think so :)

@tfuxu tfuxu merged commit d565375 into GradienceTeam:main Jun 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@daudix daudix daudix approved these changes

@tfuxu tfuxu tfuxu approved these changes

Assignees
No one assigned
Labels
area/UX enhancement New feature or request status/pr-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@salarua @daudix @tfuxu @0xMRTT