-
Notifications
You must be signed in to change notification settings - Fork 51
Implement backup functionality for gtk.css #301
Conversation
I'm trying to implement the restore functionality now, it's taking a bit longer than expected. |
If you check
|
Could you show the full traceback? Currently, the management of presets is very basic. Having the ability to restore, backup would be great 👍. |
Also for the style, please use 4spaces or 1 tab (there is a lot of style change in your PR |
|
Also, I suggest to join the matrix room or the discord server (they are bridged) Link to the matrix room on the README |
Oops |
I still haven't been able to get that code to work. Am I missing some weird thing in GTK? |
Same error ? |
yea, and I can't get it to build again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This formatting across whole main.py
is very confusing, as it's hard to even see what changes you've added. You should start again with a clean file, put changes related to PR in it, and maybe add formatting in another commit.
Yup, I kept on getting inconsistent uses of spaces and tabs for indentation errors since I was stupidly trying to do actual development work with builder so I converted the whole file to tabs using Pycharm. I'll take the methods out and put them back in then push again. |
Instead of just overwriting
gtk.css
with a newgtk.css
when applying the theme, we write the current contents ofgtk.css
togtk.css.bak
then write apply our changes togtk.css