chore: resolved comments from pr

GovConnex · May 20, 2024 · f1cee9e · f1cee9e
1 parent 4ff9bc3
commit f1cee9e
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 3 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@govconnex/ui",
-  "version": "0.0.177",
+  "version": "0.0.178",
   "description": "GovConnex UI - React Component Library",
   "scripts": {
     "build:tokens": "./tokens-build.sh",

diff --git a/src/components/Dropdown/Dropdown.stories.tsx b/src/components/Dropdown/Dropdown.stories.tsx
@@ -46,6 +46,7 @@ export const WithSelectedOption = Template.bind({});
 WithSelectedOption.args = {
   ...Default.args,
   defaultValue: "1",
+  maxWidth: "40%",
 };
 
 export const MultipleSelect = Template.bind({});

diff --git a/src/components/Dropdown/Dropdown.tsx b/src/components/Dropdown/Dropdown.tsx
@@ -11,10 +11,18 @@ import {ListItem} from "../List";
 import Chip from "../Chip";
 import {faChevronDown, faSearch} from "@fortawesome/pro-regular-svg-icons";
 
+export interface Option {
+  id: string | number;
+  text: string;
+  selected?: boolean;
+  category?: string;
+  endAdornment?: React.ReactNode;
+}
+
 export interface DropdownProps {
   label?: string;
   placeholder?: string;
-  options?: any;
+  options?: Option[];
   loading?: boolean;
   defaultValue?: React.ReactNode;
   maxWidth?: string;
@@ -113,11 +121,13 @@ const Dropdown = ({
             >
               {hasSelectedCount ? (
                 !notSelectedCount ? (
+                  // needed to disable because eslint is looking for aria attribute role
                   // eslint-disable-next-line
                   <Chip priority="low" role="primary" size="md">
                     ALL
                   </Chip>
                 ) : selectedCount ? (
+                  // needed to disable because eslint is looking for aria attribute role
                   // eslint-disable-next-line
                   <Chip priority="low" role="primary" size="md">
                     {selectedCount}
@@ -162,7 +172,7 @@ const Dropdown = ({
               padding: "0px",
               zIndex: 9,
               width: "calc(100% - 40px)",
-              maxWidth: maxWidth ? maxWidth : "40%",
+              maxWidth: maxWidth ? maxWidth : "none",
             }}
           >
             <MenuList style={{position: "relative"}}>