Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file_iterator: implement a _copy() function #286

Merged
merged 2 commits into from
Aug 20, 2024
Merged

file_iterator: implement a _copy() function #286

merged 2 commits into from
Aug 20, 2024

Conversation

Gottox
Copy link
Owner

@Gottox Gottox commented Aug 16, 2024

This function creates a copy of the iterator that has the same state as the original iterator.

@Gottox Gottox force-pushed the add/iterator-copy branch 2 times, most recently from e09a023 to 61dfd39 Compare August 19, 2024 07:23
This function creates a copy of the iterator that has the same state as
the original iterator.
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 53.19149% with 66 lines in your changes missing coverage. Please review.

Project coverage is 64.10%. Comparing base (13c79fd) to head (43ecf72).
Report is 3 commits behind head on main.

Files Patch % Lines
libsqsh/src/file/fragment_view.c 20.68% 21 Missing and 2 partials ⚠️
common/src/reader/reader.c 63.63% 6 Missing and 6 partials ⚠️
libsqsh/src/file/file_iterator.c 63.63% 4 Missing and 4 partials ⚠️
libsqsh/src/mapper/map_manager.c 20.00% 7 Missing and 1 partial ⚠️
libsqsh/src/mapper/map_reader.c 53.84% 3 Missing and 3 partials ⚠️
libsqsh/src/mapper/map_iterator.c 68.75% 3 Missing and 2 partials ⚠️
libsqsh/src/extract/extract_view.c 73.33% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #286      +/-   ##
==========================================
- Coverage   64.37%   64.10%   -0.27%     
==========================================
  Files          75       75              
  Lines        5752     5893     +141     
  Branches      874      903      +29     
==========================================
+ Hits         3703     3778      +75     
- Misses       1531     1577      +46     
- Partials      518      538      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gottox Gottox marked this pull request as ready for review August 20, 2024 16:18
Copy link

sonarcloud bot commented Aug 20, 2024

@Gottox Gottox merged commit 058077b into main Aug 20, 2024
16 checks passed
@Gottox Gottox deleted the add/iterator-copy branch August 20, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant