config: split .compression_lru_size for data and metablocks #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #278 +/- ##
==========================================
- Coverage 64.76% 64.75% -0.02%
==========================================
Files 74 74
Lines 5535 5541 +6
Branches 830 833 +3
==========================================
+ Hits 3585 3588 +3
Misses 1471 1471
- Partials 479 482 +3 ☔ View full report in Codecov by Sentry. |
Gottox
force-pushed
the
add/split_lru_for_data_and_metablock
branch
from
166bf78
to
1186d24
Compare
|
|
Should this have done something with the |
Merged
|
You are right, memcpy will do an out of bondse read, i totally forgot about that. Nonetheless, I'll keep the field as it is and instead change memcpy. Thanks for noticing that! |
|
Fixed in #291 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.