Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recycle stack items in SqshTreeTraversal on pop #274

Merged
merged 2 commits into from
Jul 28, 2024

Conversation

Dr-Emann
Copy link
Contributor

This allows re-using the stack items after popping.

Copy link

sonarcloud bot commented Jul 28, 2024

Copy link

codecov bot commented Jul 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.76%. Comparing base (8eff9ad) to head (8d90f88).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #274   +/-   ##
=======================================
  Coverage   64.76%   64.76%           
=======================================
  Files          74       74           
  Lines        5535     5535           
  Branches      830      830           
=======================================
  Hits         3585     3585           
  Misses       1471     1471           
  Partials      479      479           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gottox
Copy link
Owner

Gottox commented Jul 28, 2024

Ah, that's actually a memory leak you fixed!

@Gottox Gottox merged commit da70b06 into Gottox:main Jul 28, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants