mapper: add official support for custom mappers #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #228 +/- ##
==========================================
- Coverage 63.89% 63.82% -0.08%
==========================================
Files 72 72
Lines 5337 5329 -8
Branches 772 773 +1
==========================================
- Hits 3410 3401 -9
Misses 1497 1497
- Partials 430 431 +1 ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Gottox
force-pushed
the
add/custom_mappers
branch
from
9e10874
to
5b64357
Compare
| goto out; | ||
| } | ||
| curl_mapper->url = strdup(input); | ||
| curl_mapper->handle = curl_easy_init(); |
Check failure
Code scanning / SonarCloud
Weak SSL/TLS protocols should not be used
Gottox
force-pushed
the
add/custom_mappers
branch
from
fc64565
to
bbf3a2f
Compare
Gottox
force-pushed
the
add/custom_mappers
branch
2 times, most recently
from
faa0a68
to
e3ca8a3
Compare
This commit makes the mappers more decoupled from the rest of libsqsh. The user data is now set and retrieved a pointer instead through a public API instead of accessing SqshMapper directly. This makes the mappers more opaque to the rest of libsqsh.
Gottox
force-pushed
the
add/custom_mappers
branch
from
86c3dbb
to
8d0d068
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.