Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file: use own getter for the symlink size #183

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

Gottox
Copy link
Owner

@Gottox Gottox commented Dec 6, 2023

This change adds a new getter to retrieve the size of a symlink. Before this change the file_size getter was used to retrieve the size. This resulted in situations where the file size could be misinterpreted as a length for a symlink even though the file wasn't a symlink.

This change adds a new getter to retrieve the size of a symlink. Before
this change the file_size getter was used to retrieve the size. This
resulted in situations where the file size could be misinterpreted as a
length for a symlink even though the file wasn't a symlink.
Copy link

sonarcloud bot commented Dec 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (f3e6792) 62.40% compared to head (bd4dcd8) 62.33%.

Files Patch % Lines
libsqsh/src/file/inode_symlink.c 37.50% 5 Missing ⚠️
libsqsh/src/file/inode_null.c 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #183      +/-   ##
==========================================
- Coverage   62.40%   62.33%   -0.08%     
==========================================
  Files          68       68              
  Lines        5006     5012       +6     
  Branches      733      733              
==========================================
  Hits         3124     3124              
- Misses       1458     1464       +6     
  Partials      424      424              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gottox Gottox merged commit b0f21e8 into main Dec 6, 2023
29 checks passed
@Gottox Gottox deleted the improve/symlink-do-not-use-filesize branch December 15, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant