Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract: lookup extractor implementation once #158

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

Gottox
Copy link
Owner

@Gottox Gottox commented Oct 25, 2023

Instead of looking up the extractor implementation every time a new extractor is initialized, lookup the implementation once in the extract manager.

Instead of looking up the extractor implementation every time a new
extractor is initialized, lookup the implementation once in the extract
manager.
@sonarcloud
Copy link

sonarcloud bot commented Oct 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (6284334) 60.44% compared to head (e381e46) 60.42%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #158      +/-   ##
==========================================
- Coverage   60.44%   60.42%   -0.02%     
==========================================
  Files          59       59              
  Lines        4702     4700       -2     
  Branches      708      708              
==========================================
- Hits         2842     2840       -2     
  Misses       1455     1455              
  Partials      405      405              
Files Coverage Δ
libsqsh/src/extract/extractor.c 71.42% <ø> (-0.41%) ⬇️
libsqsh/src/extract/extract_manager.c 74.44% <75.00%> (-0.29%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gottox Gottox merged commit 6bb3a3c into main Oct 25, 2023
25 checks passed
@Gottox Gottox deleted the improve/lookup-extractor-once branch November 18, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant