directory_iterator: un-inline _inode_number #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change partially reverts d068ca4 as it breaks the ABI compatibility of the library. It re-introduces sqsh_directory_iterator_inode_number() as a non-inline function.
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #114 +/- ##
==========================================
- Coverage 59.21% 59.19% -0.03%
==========================================
Files 58 58
Lines 4742 4744 +2
Branches 710 710
==========================================
Hits 2808 2808
- Misses 1524 1526 +2
Partials 410 410
☔ View full report in Codecov by Sentry. |
|
Should be able to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change partially reverts d068ca4 as it breaks the ABI compatibility of the library. It re-introduces sqsh_directory_iterator_inode_number() as a non-inline function.