file_iterator: return correct error when iterator is not a file #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes the error code that was returned when a file iterator was initialized with a directory. Before this change, the iterator treated all file types as regular files and failed when they returned bogus file addresses. That works, but it is fragile and not the correct behavior. This change adds a check to the iterator to ensure that it is initialized with a file and returns `-SQSH_ERROR_NOT_A_FILE` when it is not.
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #110 +/- ##
==========================================
+ Coverage 59.17% 59.23% +0.05%
==========================================
Files 58 58
Lines 4728 4732 +4
Branches 707 708 +1
==========================================
+ Hits 2798 2803 +5
+ Misses 1522 1521 -1
Partials 408 408
☔ View full report in Codecov by Sentry. |
Gottox
added a commit
that referenced
this pull request
Sep 5, 2023
file_iterator: return correct error when iterator is not a file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the error code that was returned when a file iterator was initialized with a directory. Before this change, the iterator treated all file types as regular files and failed when they returned bogus file addresses. That works, but it is fragile and not the correct behavior.
This change adds a check to the iterator to ensure that it is initialized with a file and returns
-SQSH_ERROR_NOT_A_FILEwhen it is not.fixes #108.