Merge pull request #283 from Gottox/improve/extract_view-cleanup

extract_view: remove field offset. Was never used.
Gottox · Aug 14, 2024 · a17cd88 · a17cd88
2 parents a1d880f + 80781cf
commit a17cd88
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/libsqsh/include/sqsh_extract_private.h b/libsqsh/include/sqsh_extract_private.h
@@ -254,7 +254,6 @@ struct SqshExtractView {
 	 */
 	struct SqshExtractManager *manager;
 	const struct CxBuffer *buffer;
-	size_t offset;
 	size_t size;
 };
 

diff --git a/libsqsh/src/extract/extract_view.c b/libsqsh/src/extract/extract_view.c
@@ -42,7 +42,6 @@ sqsh__extract_view_init(
 		const struct SqshMapReader *reader) {
 	int rv = 0;
 	view->manager = manager;
-	view->offset = 0;
 	view->buffer = NULL;
 
 	rv = sqsh__extract_manager_uncompress(manager, reader, &view->buffer);
@@ -61,8 +60,7 @@ sqsh__extract_view_init(
 
 const uint8_t *
 sqsh__extract_view_data(const struct SqshExtractView *view) {
-	const uint8_t *data = cx_buffer_data(view->buffer);
-	return &data[view->offset];
+	return cx_buffer_data(view->buffer);
 }
 
 size_t
@@ -79,6 +77,5 @@ sqsh__extract_view_cleanup(struct SqshExtractView *view) {
 	}
 	view->buffer = NULL;
 	view->size = 0;
-	view->offset = 0;
 	return rv;
 }