OpenNTFGH-67 Unexpected webpack require behaviour

In WebPack calling require([x, y, z]), callback); where "y" does not exist, throws an exception. In Dojo the same call would still callback with a valid x + z. Fixes OpenNTFGH-67 Signed-off-by: Gordon Smith <[email protected]>
GordonSmith · Oct 19, 2017 · 28ed887 · 28ed887
1 parent 19f842c
commit 28ed887
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/lib/DojoAMDMainTemplate.runtime.js b/lib/DojoAMDMainTemplate.runtime.js
@@ -86,7 +86,12 @@ module.exports = function() {
 			}
 		}
 		if (!result) {
-			throw new Error('Module not found: ' + mid);
+			var msg = 'Module not found: ' + mid;
+			if (noInstall) {
+				throw new Error(msg);
+			} else {
+				console.error(msg);
+			}
 		}
 		return result;
 	}

diff --git a/test/TestCases/dependencies/simple/index.js b/test/TestCases/dependencies/simple/index.js
@@ -1,4 +1,4 @@
-define(["exports", "module", "./dep"], function(exports, module, dep) {
+define(["exports", "module", "./dep"], function (exports, module, dep) {
 	it("should compile", function(done) {
 		done();
 	});
@@ -39,6 +39,15 @@ define(["exports", "module", "./dep"], function(exports, module, dep) {
 		});
 	});
 
+	it("runtime require", function (done) {
+		var deps = ["missingModule", "test/dep"];
+		require(deps, function (reqMissingModule, reqDep) {
+			(typeof reqMissingModule).should.be.eql("undefined");
+			reqDep.should.be.eql(dep);
+			done();
+		});
+	});
+
 	dep.runTests();
 
 });