Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: open files on linux #765

Merged
merged 2 commits into from
Oct 3, 2024
Merged

fix: open files on linux #765

merged 2 commits into from
Oct 3, 2024

Conversation

AyaseFile
Copy link
Contributor

No description provided.

@monkeyWie
Copy link
Member

monkeyWie commented Sep 29, 2024

Thanks, have you tested it??

Copy link

codecov bot commented Sep 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.12%. Comparing base (5ad15cc) to head (7a6cbcc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #765      +/-   ##
==========================================
- Coverage   61.18%   61.12%   -0.06%     
==========================================
  Files          35       35              
  Lines        3694     3694              
==========================================
- Hits         2260     2258       -2     
- Misses       1161     1163       +2     
  Partials      273      273              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AyaseFile
Copy link
Contributor Author

AyaseFile commented Sep 30, 2024

Tested on GNOME and KDE. If xdg-open fails, support for more file managers may be needed.
I tried showing error messages, but I didn't mean to change too much.

@monkeyWie monkeyWie added the bug Something isn't working label Oct 3, 2024
@monkeyWie monkeyWie merged commit 1d86d14 into GopeedLab:main Oct 3, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants