[PR] 유저 프로필 #62
Merged
[PR] 유저 프로필 #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
userEmail에 대해서 쿼리 파라미터로 받아오는 것으로 수정했습니다.
gamjatan9
added
documentation
kangsinbeom
approved these changes
May 17, 2024
| const ProfileTable = () => { | ||
| const { register, handleSubmit, reset } = useForm<UserModify>(); | ||
|
|
||
| useEffect(() => { |
There was a problem hiding this comment.
여기 왜 react-query 안 쓰셨죠? get해오는 부분 같은데 이부분은 수정이 이루어졌으면 합니다.
| @@ -9,22 +8,23 @@ import SkeletonBox from '@/components/loader/skeleton'; | |||
| import Article from '@/components/shared/article'; | |||
|
|
|||
| const ArticlesMenu = ({ value }: Pick<MypageArticles, 'value'>) => { | |||
| const { email } = useEmail(); | |||
| const queryEmail = new URLSearchParams(location.search).get('user'); | |||
There was a problem hiding this comment.
이거 searchParmas로 email을 설정한 이유가 있나요? mypage/email=~~이런식으로 되있는 건가요?
const {postId} = useParams()
| getNextPageParam: (lastPage) => lastPage.nextPage, | ||
| staleTime: 1000 * 60 * 5, // 5분 | ||
| }); | ||
| const { data, fetchNextPage, hasNextPage, isFetchingNextPage, isLoading } = |
There was a problem hiding this comment.
suspense 사용해서 나타내시면 좋을 것 같습니다
const {data} = useSuspenseInfiniteQuery(options)
// 또는 hooks로 빼서
const {data} = useGetProfile()
| const queryEmail = new URLSearchParams(location.search).get('user'); | ||
| let userData; | ||
|
|
||
| if (queryEmail) { |
There was a problem hiding this comment.
이건 api가 아쉽네요 하나로 합쳐져야 한다고 생각을 합니다.
if (jwt) {
if (emil) {
// 이메일이 있으면 다른 유저정보를 불러오는 것임
} else {
// 이메일이 없으면 자기 자신 유저정보를 불러오는 것임
}
} else {
if (email) {
상대방 정보를 보고 싶은 것이니 그냥 가능
}
내 유저정보를 불러올 수 없으니 로그인 페이지로 이동시켜야 함
}
// 이런 플로우를 가진 api가 있으면 딱입니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Checklist
feat: 유저 조회 기능 구현)🧩 이슈 번호
🎨 완성 이미지
작업 이미지
👩💻 공유 포인트 및 논의 사항