[PR] 전체 마무리 및 댓글 기능 구현 #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
401과 400에 대해서 에러 메세지가 알럿창으로 뜨게끔 구현하였음
gamjatan9
approved these changes
May 17, 2024
j2an777
approved these changes
May 17, 2024
| <Suspense fallback={<>loading</>}> | ||
| <BrowserRouter> | ||
| <ErrorBoundary navigate={navigate}> | ||
| <Suspense fallback={<>loading</>}> |
There was a problem hiding this comment.
suspense 이거 삭제해주세요.
메인 페이지 경우에는 Nav, MainList, MainExtra가 MainList 컴포넌트만 독립적으로 분리 시킬거라서 suspense 해놨습니다.
| @@ -13,48 +13,48 @@ import ErrorPage from '../pages/error'; | |||
| export const routers = [ | |||
| { | |||
| path: '/', | |||
| component: MainPage, | |||
| element: MainPage, | |||
There was a problem hiding this comment.
component -> element 변경하신 이유를 알고싶군요.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Checklist
feat: 유저 조회 기능 구현)🧩 이슈 번호
🎨 완성 이미지
작업 이미지
👩💻 공유 포인트 및 논의 사항