[PR] 공통 UI 컴포넌트 조정 #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
버튼 크기 통일, 폰트 크기 통일, 마이페이지 및 nav바 ui 수정
baseurl 수정, 유저관련 api 추가
gamjatan9
added
documentation
kangsinbeom
approved these changes
May 10, 2024
| background: ${({ background = colors.yellow }) => background}; | ||
| color: ${({ color = 'white' }) => color}; | ||
| font-size: 20px; | ||
| font-weight: 700; | ||
| ${({ typography = 't1' }) => typographyMap[typography]} |
There was a problem hiding this comment.
button style 정의할 때 styles/button.ts 여기 ts 파일이 있는데 여기서 새롭게 정의를 하죠 typography 사용하는 거는 span이나 p tag에서만 쓰면 좋을 것 같습니다.
|
|
||
| import styled from '@emotion/styled'; | ||
| import { colors } from '../../styles/colorPalette'; | ||
| import { typographyMap } from '@/styles/typography'; | ||
|
|
||
| export const NavContainer = styled.div` |
There was a problem hiding this comment.
이거 styled component들 네이밍 컨벤션을 좀 정했으면 좋겠어요 Container로 저는 정의하는데 앞에 관련 컴포넌트 이름 붙일까요?
| @@ -11,7 +11,7 @@ export const getAuthAxios = (accessToken?: string) => { | |||
| }; | |||
|
|
|||
| const authAxios = axios.create({ | |||
| baseURL: 'http://211.206.94.24:9999', | |||
| baseURL: 'http://13.124.54.157:8080', | |||
| @@ -0,0 +1,19 @@ | |||
| import { useInfiniteQuery } from '@tanstack/react-query'; | |||
There was a problem hiding this comment.
hooks file 안에는 2개 export하고 있는 것보다 하나의 기능만 넣어주세요
| const response = await fetch(`${api}?page=${pageParam}&limit=${limit}`); | ||
| const data = await response.json(); | ||
| // 다음 페이지 계산: 'done'이 false면 다음 페이지 번호, true면 undefined | ||
| const nextPage = data.pageInfo.done ? undefined : pageParam + 1; |
There was a problem hiding this comment.
nexPage에 undefined보단 hasNext에 null or false와 원시 값을 사용하는 게 좋을 것 같습니다 undefined는 개발자가 정의하는 값이 아니라고 들었습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Checklist
feat: 유저 조회 기능 구현)🧩 이슈 번호
🎨 완성 이미지
작업 이미지
👩💻 공유 포인트 및 논의 사항