This repository has been archived by the owner on Jul 16, 2024. It is now read-only.
Optimize kts logic #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goooler
commented
Jan 30, 2022
| @@ -1,6 +1,6 @@ | |||
| import com.android.build.gradle.LibraryExtension | |||
|
|
|||
| setupBase<LibraryExtension>() | |||
| setupBase<LibraryExtension>(LibModule.Base) | |||
There was a problem hiding this comment.
Inject module name now in setupBase.
Goooler
commented
Jan 30, 2022
Comment on lines
+3
to
+6
| // TODO: Make Module sealed | ||
| interface Module { | ||
| val tag: String | ||
| } |
There was a problem hiding this comment.
Seems issues in buildSrc module make Kotlin lang level is 1.4.
Goooler
commented
Jan 30, 2022
Comment on lines
+22
to
+24
| enum class AppModule(override val tag: String, val appName: String, val appId: String) : Module { | ||
| App("app", "Demo", "io.goooler.demoapp"), | ||
| Test("app", "Test", "io.goooler.test") |
There was a problem hiding this comment.
Separate app modules to new enum classes.
Goooler
commented
Jan 30, 2022
Comment on lines
+27
to
+31
| enum class BuildConfigField(val key: String, val value: Any) { | ||
| VersionCode("VERSION_CODE", appVersionCode), | ||
| VersionName("VERSION_NAME", appVersionName), | ||
| CdnPrefix("CDN_PREFIX", "https://raw.githubusercontent.com/"), | ||
| ApiHost("API_HOST", "https://api.github.com/") |
Goooler
commented
Jan 30, 2022
Comment on lines
-80
to
-85
| fun VariantDimension.putBuildConfigStringField(name: String, value: String?) { | ||
| buildConfigField("String", name, "\"$value\"") | ||
| } | ||
|
|
||
| fun VariantDimension.putBuildConfigIntField(name: String, value: Int) { | ||
| buildConfigField("Integer", name, value.toString()) |
There was a problem hiding this comment.
Merge two functions to a new one.
Goooler
commented
Jan 30, 2022
Comment on lines
-240
to
-259
| project(Module.Base.moduleName), | ||
| project(Module.Adapter.moduleName), | ||
|
|
||
| // router | ||
| Libs.arouter, | ||
|
|
||
| // UI | ||
| Libs.constraintLayout, | ||
| Libs.cardView, | ||
| Libs.material, | ||
| *Libs.smartRefreshLayout, | ||
| Libs.photoView, | ||
|
|
||
| // utils | ||
| *Libs.hilt, | ||
| *Libs.room, | ||
| *Libs.rx, | ||
| *Libs.moshi, | ||
| Libs.collection, | ||
| Libs.utils |
There was a problem hiding this comment.
Move unnecessary deps into common module.
Goooler
added
build
enhancement
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to Unresolved reference: isShrinkResources,
isShrinkResourceswas re-added fromAGP 7.0 beta 1.