This repository has been archived by the owner on Jul 16, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 11
Use shallow copy on diff items #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # biz/main/src/main/kotlin/io/goooler/demoapp/main/model/MainCommonVhModel.kt
Goooler
commented
Apr 24, 2022
adapter/src/main/kotlin/io/goooler/demoapp/adapter/rv/diff/BaseRvDiffAdapter.kt
Show resolved
Hide resolved
Merged
Goooler
changed the title
Use deep clone in BaseRvDiffAdapter
Use deep clone on diff items
Apr 24, 2022
* Add like count logic * Diff fullName * Diff likeCount * Parcel likeCount * Make fullName not default * Deep clone the one changed * Run on default thread * Revert changes in BaseRvDiffAdapter * Extract refreshListItems * Use shallow copy * Revert "Apply parcelize plugin" This reverts commit aa093e6. * Remove refreshListItems
Goooler
commented
Apr 24, 2022
Comment on lines
+59
to
+62
list += if (model is MainCommonVhModel.Repo && model.fullName == fullName) { | ||
model.copy(shareCount = model.shareCount + 1) | ||
} else | ||
model |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Conflicts: # base/src/main/kotlin/io/goooler/demoapp/base/util/BaseExtensions.kt
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.