Skip to content
This repository has been archived by the owner on Jul 16, 2024. It is now read-only.

Use shallow copy on diff items #103

Merged
merged 17 commits into from
Apr 24, 2022
Merged

Use shallow copy on diff items #103

merged 17 commits into from
Apr 24, 2022

Conversation

Goooler
Copy link
Owner

@Goooler Goooler commented Apr 24, 2022

No description provided.

@Goooler Goooler added the enhancement New feature or request label Apr 24, 2022
@Goooler Goooler added this to the 1.6.0 milestone Apr 24, 2022
# Conflicts:
#	biz/main/src/main/kotlin/io/goooler/demoapp/main/model/MainCommonVhModel.kt
@Goooler Goooler mentioned this pull request Apr 24, 2022
@Goooler Goooler changed the title Use deep clone in BaseRvDiffAdapter Use deep clone on diff items Apr 24, 2022
* Add like count logic

* Diff fullName

* Diff likeCount

* Parcel likeCount

* Make fullName not default

* Deep clone the one changed

* Run on default thread

* Revert changes in BaseRvDiffAdapter

* Extract refreshListItems

* Use shallow copy

* Revert "Apply parcelize plugin"

This reverts commit aa093e6.

* Remove refreshListItems
Comment on lines +59 to +62
list += if (model is MainCommonVhModel.Repo && model.fullName == fullName) {
model.copy(shareCount = model.shareCount + 1)
} else
model
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Goooler Goooler changed the title Use deep clone on diff items Use shallow copy on diff items Apr 24, 2022
@Goooler Goooler mentioned this pull request Apr 24, 2022
# Conflicts:
#	base/src/main/kotlin/io/goooler/demoapp/base/util/BaseExtensions.kt
@Goooler Goooler merged commit 0b69cb1 into trunk Apr 24, 2022
@Goooler Goooler deleted the diff branch April 24, 2022 17:26
@Goooler Goooler mentioned this pull request Apr 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant