Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block: Uncontrolled input warning #8242

Merged
merged 2 commits into from
Jul 8, 2021
Merged

Block: Uncontrolled input warning #8242

merged 2 commits into from
Jul 8, 2021

Conversation

spacedmonkey
Copy link
Contributor

Context

Summary

Relevant Technical Choices

To-do

Early in the render of the block, the value assigned to checked is undefined. This triggers the error. If undefined set to default value of false.

User-facing changes

Testing Instructions

QA

  • This is a non-user-facing change and requires no QA

This PR can be tested by following these steps:

UAT

  • UAT should use the same steps as above.

This PR can be tested by following these steps:

Reviews

Does this PR have a security-related impact?

Does this PR change what data or activity we track or use?

Does this PR have a legal-related impact?

Checklist

  • This PR addresses an existing issue and I have linked this PR to it in ZenHub
  • I have tested this code to the best of my abilities
  • I have verified accessibility to the best of my abilities (docs)
  • I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
  • This PR contains automated tests (unit, integration, and/or e2e) to verify the code works as intended (docs)
  • I have added documentation where necessary
  • I have added a matching Type: XYZ label to the PR

Fixes #8096

@spacedmonkey spacedmonkey added Type: Bug Something isn't working P2 Should do soon Group: WordPress Changes related to WordPress or Gutenberg integration Pod: WP & Infra Group: Blocks Issues related to the provided Gutenberg Blocks labels Jul 8, 2021
@spacedmonkey spacedmonkey requested a review from swissspidy July 8, 2021 12:20
@spacedmonkey spacedmonkey self-assigned this Jul 8, 2021
@google-cla google-cla bot added the cla: yes label Jul 8, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2021

Size Change: +3 B (0%)

Total Size: 2.2 MB

ℹ️ View Unchanged
Filename Size Change
assets/css/carousel-view-rtl.css 701 B 0 B
assets/css/carousel-view.css 701 B 0 B
assets/css/edit-story-rtl.css 277 B 0 B
assets/css/edit-story.css 277 B 0 B
assets/css/stories-dashboard-rtl.css 276 B 0 B
assets/css/stories-dashboard.css 276 B 0 B
assets/css/vendors-edit-story-rtl.css 706 B 0 B
assets/css/vendors-edit-story.css 706 B 0 B
assets/css/web-stories-block-rtl.css 3.21 kB 0 B
assets/css/web-stories-block.css 3.24 kB 0 B
assets/css/web-stories-embed-rtl.css 288 B 0 B
assets/css/web-stories-embed.css 288 B 0 B
assets/css/web-stories-list-styles-rtl.css 2.24 kB 0 B
assets/css/web-stories-list-styles.css 2.25 kB 0 B
assets/css/web-stories-theme-style-twentyeleven-rtl.css 102 B 0 B
assets/css/web-stories-theme-style-twentyeleven.css 102 B 0 B
assets/css/web-stories-theme-style-twentyfifteen-rtl.css 251 B 0 B
assets/css/web-stories-theme-style-twentyfifteen.css 251 B 0 B
assets/css/web-stories-theme-style-twentyfourteen-rtl.css 287 B 0 B
assets/css/web-stories-theme-style-twentyfourteen.css 287 B 0 B
assets/css/web-stories-theme-style-twentyseventeen-rtl.css 288 B 0 B
assets/css/web-stories-theme-style-twentyseventeen.css 288 B 0 B
assets/css/web-stories-theme-style-twentysixteen-rtl.css 224 B 0 B
assets/css/web-stories-theme-style-twentysixteen.css 224 B 0 B
assets/css/web-stories-theme-style-twentyten-rtl.css 143 B 0 B
assets/css/web-stories-theme-style-twentyten.css 143 B 0 B
assets/css/web-stories-theme-style-twentytwelve-rtl.css 256 B 0 B
assets/css/web-stories-theme-style-twentytwelve.css 256 B 0 B
assets/css/web-stories-theme-style-twentytwenty-rtl.css 86 B 0 B
assets/css/web-stories-theme-style-twentytwenty.css 86 B 0 B
assets/css/web-stories-theme-style-twentytwentyone-rtl.css 263 B 0 B
assets/css/web-stories-theme-style-twentytwentyone.css 264 B 0 B
assets/css/web-stories-widget-rtl.css 484 B 0 B
assets/css/web-stories-widget.css 484 B 0 B
assets/js/carousel-view.js 3.72 kB 0 B
assets/js/chunk-fonts-********************.js 45.9 kB 0 B
assets/js/chunk-web-stories-template-0-********************.js 471 B 0 B
assets/js/chunk-web-stories-template-10-********************.js 7.94 kB 0 B
assets/js/chunk-web-stories-template-12-********************.js 466 B 0 B
assets/js/chunk-web-stories-template-16-********************.js 7.82 kB 0 B
assets/js/chunk-web-stories-template-18-********************.js 479 B 0 B
assets/js/chunk-web-stories-template-22-********************.js 8.06 kB 0 B
assets/js/chunk-web-stories-template-24-********************.js 423 B 0 B
assets/js/chunk-web-stories-template-28-********************.js 9.69 kB 0 B
assets/js/chunk-web-stories-template-30-********************.js 456 B 0 B
assets/js/chunk-web-stories-template-34-********************.js 8.51 kB 0 B
assets/js/chunk-web-stories-template-36-********************.js 450 B 0 B
assets/js/chunk-web-stories-template-4-********************.js 7.96 kB 0 B
assets/js/chunk-web-stories-template-40-********************.js 6.94 kB 0 B
assets/js/chunk-web-stories-template-42-********************.js 444 B 0 B
assets/js/chunk-web-stories-template-46-********************.js 9.2 kB 0 B
assets/js/chunk-web-stories-template-48-********************.js 460 B 0 B
assets/js/chunk-web-stories-template-52-********************.js 6.01 kB 0 B
assets/js/chunk-web-stories-template-54-********************.js 482 B 0 B
assets/js/chunk-web-stories-template-58-********************.js 7.98 kB 0 B
assets/js/chunk-web-stories-template-6-********************.js 499 B 0 B
assets/js/chunk-web-stories-template-60-********************.js 486 B 0 B
assets/js/chunk-web-stories-template-64-********************.js 7.79 kB 0 B
assets/js/chunk-web-stories-template-66-********************.js 509 B 0 B
assets/js/chunk-web-stories-template-70-********************.js 8.33 kB 0 B
assets/js/chunk-web-stories-template-72-********************.js 445 B 0 B
assets/js/chunk-web-stories-template-76-********************.js 8.6 kB 0 B
assets/js/chunk-web-stories-textset-0-********************.js 5.29 kB 0 B
assets/js/chunk-web-stories-textset-1-********************.js 6.81 kB 0 B
assets/js/chunk-web-stories-textset-2-********************.js 7.92 kB 0 B
assets/js/chunk-web-stories-textset-3-********************.js 15.4 kB 0 B
assets/js/chunk-web-stories-textset-4-********************.js 4.43 kB 0 B
assets/js/chunk-web-stories-textset-5-********************.js 5.71 kB 0 B
assets/js/chunk-web-stories-textset-6-********************.js 5.5 kB 0 B
assets/js/chunk-web-stories-textset-7-********************.js 10.4 kB 0 B
assets/js/edit-story.js 545 kB 0 B
assets/js/lightbox.js 991 B 0 B
assets/js/stories-dashboard.js 451 kB 0 B
assets/js/tinymce-button.js 3.48 kB 0 B
assets/js/vendors-chunk-ffmpeg-********************.js 5.6 kB 0 B
assets/js/vendors-edit-story-********************.js 68.4 kB 0 B
assets/js/vendors-edit-story-stories-dashboard-********************.js 235 kB 0 B
assets/js/vendors-web-animations-js-********************.js 14.6 kB 0 B
assets/js/web-stories-activation-notice.js 65.1 kB 0 B
assets/js/web-stories-block.js 569 kB +3 B (0%)
assets/js/web-stories-embed.js 493 B 0 B
assets/js/web-stories-widget.js 984 B 0 B

compressed-size-action

swissspidy
swissspidy approved these changes Jul 8, 2021
View reviewed changes
Copy link
Collaborator

@swissspidy swissspidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@swissspidy swissspidy merged commit 6f9bddd into main Jul 8, 2021
@swissspidy swissspidy deleted the fix/block-error branch July 8, 2021 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swissspidy swissspidy swissspidy approved these changes

Assignees

@spacedmonkey spacedmonkey

Labels
Group: Blocks Issues related to the provided Gutenberg Blocks Group: WordPress Changes related to WordPress or Gutenberg integration P2 Should do soon Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Block: Uncontrolled input warning
2 participants
@spacedmonkey @swissspidy