Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E Tests: retry flaky tests #7758

Merged
merged 3 commits into from
May 27, 2021
Merged

E2E Tests: retry flaky tests #7758

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
412b0b7
Retry e2e tests
spacedmonkey May 27, 2021
47d5d4f
Retry in test.
spacedmonkey May 27, 2021
d3e9bf1
Remove test.
spacedmonkey May 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/e2e-tests/src/config/bootstrap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,11 @@ const pageEvents = [];
// The Jest timeout is increased because these tests are a bit slow
jest.setTimeout(PUPPETEER_TIMEOUT || 100000);

// Retry flaky tests at most 2 times in CI (off by 1).
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is correct though. I believe retryTimes(3) means it will at most run the test 4 times, 1 normal run, then 3 retries.

if ('true' === process.env.CI) {
jest.retryTimes(3);
}

// Set default timeout for individual expect-puppeteer assertions. (Default: 500)
setDefaultOptions({ timeout: EXPECT_PUPPETEER_TIMEOUT || 500 });

Expand Down