Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PHP-Scoper to v0.16.2 #10511

Merged
merged 3 commits into from
Feb 10, 2022
Merged

Update PHP-Scoper to v0.16.2 #10511

merged 3 commits into from
Feb 10, 2022

Conversation

timarney
Copy link
Contributor

@timarney timarney commented Feb 7, 2022

Context

Updates PHP-Scoper to 0.16.2 which allows us to clean up the config file

Summary

Updates the PHP-Scoper version + config

  • Removes "str_replace" calls in the config

Relevant Technical Choices

  • Pulls in sniccwp/php-scoper-wordpress-excludes which provides .json files for WP functions, classes to exclude

User-facing changes

N/A

Testing Instructions

  • This is a non-user-facing change and requires no QA

This PR can be tested by following these steps:

Reviews

Does this PR have a security-related impact?

No outside of introduces a new package sniccwp/php-scoper-wordpress-excludes

Does this PR change what data or activity we track or use?

No

Does this PR have a legal-related impact?

No new package is MIT License

Checklist

  • This PR addresses an existing issue and I have linked this PR to it in ZenHub
  • I have tested this code to the best of my abilities
  • I have verified accessibility to the best of my abilities (docs)
  • I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
  • This code is covered by automated tests (unit, integration, and/or e2e) to verify it works as intended (docs)
  • I have added documentation where necessary
  • I have added a matching Type: XYZ label to the PR

Fixes #10407

@timarney timarney added Type: Infrastructure Changes impacting testing infrastructure or build tooling Pod: WP & Infra labels Feb 8, 2022
@timarney timarney changed the title WIP --- Fix/10407 Update PHP-Scoper to v0.16.2 Feb 8, 2022
composer.json Outdated Show resolved Hide resolved
scoper.inc.php Outdated Show resolved Hide resolved
@timarney timarney marked this pull request as ready for review February 8, 2022 12:04
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2022

Size Change: +2.29 kB (0%)

Total Size: 4.06 MB

Filename Size Change
assets/js/chunk-getStoryPropsToSave.js 1.34 MB +1.11 kB (0%)
assets/js/wp-story-editor.js 1.52 MB +1.18 kB (0%)
ℹ️ View Unchanged
Filename Size Change
assets/css/carousel-view-rtl.css 701 B 0 B
assets/css/carousel-view.css 701 B 0 B
assets/css/vendors-chunk-getStoryPropsToSave-wp-story-editor-rtl.css 699 B 0 B
assets/css/vendors-chunk-getStoryPropsToSave-wp-story-editor.css 699 B 0 B
assets/css/web-stories-block-rtl.css 4.51 kB 0 B
assets/css/web-stories-block.css 4.55 kB 0 B
assets/css/web-stories-embed-rtl.css 318 B 0 B
assets/css/web-stories-embed.css 317 B 0 B
assets/css/web-stories-list-styles-rtl.css 2.35 kB 0 B
assets/css/web-stories-list-styles.css 2.37 kB 0 B
assets/css/web-stories-theme-style-twentyeleven-rtl.css 102 B 0 B
assets/css/web-stories-theme-style-twentyeleven.css 102 B 0 B
assets/css/web-stories-theme-style-twentyfifteen-rtl.css 251 B 0 B
assets/css/web-stories-theme-style-twentyfifteen.css 251 B 0 B
assets/css/web-stories-theme-style-twentyfourteen-rtl.css 287 B 0 B
assets/css/web-stories-theme-style-twentyfourteen.css 287 B 0 B
assets/css/web-stories-theme-style-twentyseventeen-rtl.css 288 B 0 B
assets/css/web-stories-theme-style-twentyseventeen.css 288 B 0 B
assets/css/web-stories-theme-style-twentysixteen-rtl.css 224 B 0 B
assets/css/web-stories-theme-style-twentysixteen.css 224 B 0 B
assets/css/web-stories-theme-style-twentyten-rtl.css 143 B 0 B
assets/css/web-stories-theme-style-twentyten.css 143 B 0 B
assets/css/web-stories-theme-style-twentytwelve-rtl.css 256 B 0 B
assets/css/web-stories-theme-style-twentytwelve.css 256 B 0 B
assets/css/web-stories-theme-style-twentytwenty-rtl.css 86 B 0 B
assets/css/web-stories-theme-style-twentytwenty.css 86 B 0 B
assets/css/web-stories-theme-style-twentytwentyone-rtl.css 325 B 0 B
assets/css/web-stories-theme-style-twentytwentyone.css 326 B 0 B
assets/css/web-stories-widget-rtl.css 485 B 0 B
assets/css/web-stories-widget.css 485 B 0 B
assets/css/wp-dashboard-rtl.css 658 B 0 B
assets/css/wp-dashboard.css 659 B 0 B
assets/css/wp-story-editor-rtl.css 608 B 0 B
assets/css/wp-story-editor.css 609 B 0 B
assets/js/carousel-view.js 3.72 kB 0 B
assets/js/chunk-colorthief.js 2.61 kB 0 B
assets/js/chunk-focus-visible.js 997 B 0 B
assets/js/chunk-web-stories-template-0-metaData.js 529 B 0 B
assets/js/chunk-web-stories-template-0.js 10.8 kB 0 B
assets/js/chunk-web-stories-template-1-metaData.js 522 B 0 B
assets/js/chunk-web-stories-template-1.js 8.99 kB 0 B
assets/js/chunk-web-stories-template-10-metaData.js 516 B 0 B
assets/js/chunk-web-stories-template-10.js 6.96 kB 0 B
assets/js/chunk-web-stories-template-11-metaData.js 521 B 0 B
assets/js/chunk-web-stories-template-11.js 8.46 kB 0 B
assets/js/chunk-web-stories-template-12-metaData.js 480 B 0 B
assets/js/chunk-web-stories-template-12.js 9.55 kB 0 B
assets/js/chunk-web-stories-template-13-metaData.js 507 B 0 B
assets/js/chunk-web-stories-template-13.js 7.39 kB 0 B
assets/js/chunk-web-stories-template-14-metaData.js 566 B 0 B
assets/js/chunk-web-stories-template-14.js 7.53 kB 0 B
assets/js/chunk-web-stories-template-15-metaData.js 526 B 0 B
assets/js/chunk-web-stories-template-15.js 8.22 kB 0 B
assets/js/chunk-web-stories-template-16-metaData.js 570 B 0 B
assets/js/chunk-web-stories-template-16.js 10.3 kB 0 B
assets/js/chunk-web-stories-template-17-metaData.js 526 B 0 B
assets/js/chunk-web-stories-template-17.js 8.48 kB 0 B
assets/js/chunk-web-stories-template-18-metaData.js 569 B 0 B
assets/js/chunk-web-stories-template-18.js 9.28 kB 0 B
assets/js/chunk-web-stories-template-19-metaData.js 484 B 0 B
assets/js/chunk-web-stories-template-19.js 10.1 kB 0 B
assets/js/chunk-web-stories-template-2-metaData.js 571 B 0 B
assets/js/chunk-web-stories-template-2.js 9.15 kB 0 B
assets/js/chunk-web-stories-template-20-metaData.js 534 B 0 B
assets/js/chunk-web-stories-template-20.js 8.63 kB 0 B
assets/js/chunk-web-stories-template-21-metaData.js 519 B 0 B
assets/js/chunk-web-stories-template-21.js 8.97 kB 0 B
assets/js/chunk-web-stories-template-22-metaData.js 507 B 0 B
assets/js/chunk-web-stories-template-22.js 7.42 kB 0 B
assets/js/chunk-web-stories-template-23-metaData.js 586 B 0 B
assets/js/chunk-web-stories-template-23.js 7.08 kB 0 B
assets/js/chunk-web-stories-template-24-metaData.js 498 B 0 B
assets/js/chunk-web-stories-template-24.js 10.9 kB 0 B
assets/js/chunk-web-stories-template-25-metaData.js 527 B 0 B
assets/js/chunk-web-stories-template-25.js 7.18 kB 0 B
assets/js/chunk-web-stories-template-26-metaData.js 582 B 0 B
assets/js/chunk-web-stories-template-26.js 6.8 kB 0 B
assets/js/chunk-web-stories-template-27-metaData.js 527 B 0 B
assets/js/chunk-web-stories-template-27.js 7.6 kB 0 B
assets/js/chunk-web-stories-template-28-metaData.js 517 B 0 B
assets/js/chunk-web-stories-template-28.js 8.58 kB 0 B
assets/js/chunk-web-stories-template-29-metaData.js 546 B 0 B
assets/js/chunk-web-stories-template-29.js 8.51 kB 0 B
assets/js/chunk-web-stories-template-3-metaData.js 523 B 0 B
assets/js/chunk-web-stories-template-3.js 8.24 kB 0 B
assets/js/chunk-web-stories-template-30-metaData.js 560 B 0 B
assets/js/chunk-web-stories-template-30.js 7.81 kB 0 B
assets/js/chunk-web-stories-template-31-metaData.js 485 B 0 B
assets/js/chunk-web-stories-template-31.js 9.61 kB 0 B
assets/js/chunk-web-stories-template-32-metaData.js 536 B 0 B
assets/js/chunk-web-stories-template-32.js 12.3 kB 0 B
assets/js/chunk-web-stories-template-33-metaData.js 478 B 0 B
assets/js/chunk-web-stories-template-33.js 8.9 kB 0 B
assets/js/chunk-web-stories-template-34-metaData.js 554 B 0 B
assets/js/chunk-web-stories-template-34.js 7.68 kB 0 B
assets/js/chunk-web-stories-template-35-metaData.js 546 B 0 B
assets/js/chunk-web-stories-template-35.js 8.92 kB 0 B
assets/js/chunk-web-stories-template-36-metaData.js 558 B 0 B
assets/js/chunk-web-stories-template-36.js 11.6 kB 0 B
assets/js/chunk-web-stories-template-37-metaData.js 512 B 0 B
assets/js/chunk-web-stories-template-37.js 6.47 kB 0 B
assets/js/chunk-web-stories-template-38-metaData.js 556 B 0 B
assets/js/chunk-web-stories-template-38.js 7.96 kB 0 B
assets/js/chunk-web-stories-template-39-metaData.js 573 B 0 B
assets/js/chunk-web-stories-template-39.js 7.65 kB 0 B
assets/js/chunk-web-stories-template-4-metaData.js 547 B 0 B
assets/js/chunk-web-stories-template-4.js 11.5 kB 0 B
assets/js/chunk-web-stories-template-40-metaData.js 541 B 0 B
assets/js/chunk-web-stories-template-40.js 9.12 kB 0 B
assets/js/chunk-web-stories-template-41-metaData.js 557 B 0 B
assets/js/chunk-web-stories-template-41.js 7.82 kB 0 B
assets/js/chunk-web-stories-template-42-metaData.js 505 B 0 B
assets/js/chunk-web-stories-template-42.js 7.08 kB 0 B
assets/js/chunk-web-stories-template-43-metaData.js 542 B 0 B
assets/js/chunk-web-stories-template-43.js 8.42 kB 0 B
assets/js/chunk-web-stories-template-44-metaData.js 567 B 0 B
assets/js/chunk-web-stories-template-44.js 10.3 kB 0 B
assets/js/chunk-web-stories-template-45-metaData.js 547 B 0 B
assets/js/chunk-web-stories-template-45.js 7.31 kB 0 B
assets/js/chunk-web-stories-template-46-metaData.js 514 B 0 B
assets/js/chunk-web-stories-template-46.js 5 kB 0 B
assets/js/chunk-web-stories-template-47-metaData.js 574 B 0 B
assets/js/chunk-web-stories-template-47.js 8.4 kB 0 B
assets/js/chunk-web-stories-template-48-metaData.js 540 B 0 B
assets/js/chunk-web-stories-template-48.js 8.32 kB 0 B
assets/js/chunk-web-stories-template-49-metaData.js 499 B 0 B
assets/js/chunk-web-stories-template-49.js 9.8 kB 0 B
assets/js/chunk-web-stories-template-5-metaData.js 541 B 0 B
assets/js/chunk-web-stories-template-5.js 9.38 kB 0 B
assets/js/chunk-web-stories-template-50-metaData.js 485 B 0 B
assets/js/chunk-web-stories-template-50.js 8.4 kB 0 B
assets/js/chunk-web-stories-template-51-metaData.js 513 B 0 B
assets/js/chunk-web-stories-template-51.js 9.97 kB 0 B
assets/js/chunk-web-stories-template-52-metaData.js 589 B 0 B
assets/js/chunk-web-stories-template-52.js 10.1 kB 0 B
assets/js/chunk-web-stories-template-53-metaData.js 535 B 0 B
assets/js/chunk-web-stories-template-53.js 5.89 kB 0 B
assets/js/chunk-web-stories-template-54-metaData.js 531 B 0 B
assets/js/chunk-web-stories-template-54.js 7.55 kB 0 B
assets/js/chunk-web-stories-template-55-metaData.js 557 B 0 B
assets/js/chunk-web-stories-template-55.js 6.75 kB 0 B
assets/js/chunk-web-stories-template-56-metaData.js 525 B 0 B
assets/js/chunk-web-stories-template-56.js 9.55 kB 0 B
assets/js/chunk-web-stories-template-57-metaData.js 513 B 0 B
assets/js/chunk-web-stories-template-57.js 14.1 kB 0 B
assets/js/chunk-web-stories-template-58-metaData.js 539 B 0 B
assets/js/chunk-web-stories-template-58.js 5.68 kB 0 B
assets/js/chunk-web-stories-template-59-metaData.js 575 B 0 B
assets/js/chunk-web-stories-template-59.js 8.72 kB 0 B
assets/js/chunk-web-stories-template-6-metaData.js 552 B 0 B
assets/js/chunk-web-stories-template-6.js 7.07 kB 0 B
assets/js/chunk-web-stories-template-60-metaData.js 493 B 0 B
assets/js/chunk-web-stories-template-60.js 9.03 kB 0 B
assets/js/chunk-web-stories-template-7-metaData.js 552 B 0 B
assets/js/chunk-web-stories-template-7.js 7.2 kB 0 B
assets/js/chunk-web-stories-template-8-metaData.js 551 B 0 B
assets/js/chunk-web-stories-template-8.js 8.44 kB 0 B
assets/js/chunk-web-stories-template-9-metaData.js 566 B 0 B
assets/js/chunk-web-stories-template-9.js 8.48 kB 0 B
assets/js/chunk-web-stories-textset-0.js 5.27 kB 0 B
assets/js/chunk-web-stories-textset-1.js 6.76 kB 0 B
assets/js/chunk-web-stories-textset-2.js 7.88 kB 0 B
assets/js/chunk-web-stories-textset-3.js 15.4 kB 0 B
assets/js/chunk-web-stories-textset-4.js 4.38 kB 0 B
assets/js/chunk-web-stories-textset-5.js 5.68 kB 0 B
assets/js/chunk-web-stories-textset-6.js 5.49 kB 0 B
assets/js/chunk-web-stories-textset-7.js 10.4 kB 0 B
assets/js/generateBlurhash.worker.worker.js 1.52 kB 0 B
assets/js/imgareaselect.js 4.14 kB 0 B
assets/js/lightbox.js 989 B 0 B
assets/js/tinymce-button.js 3.16 kB 0 B
assets/js/vendors-chunk-ffmpeg.js 5.6 kB 0 B
assets/js/vendors-chunk-getStoryPropsToSave-chunk-resize-observer-polyfill-wp-story-editor.js 2.54 kB 0 B
assets/js/vendors-chunk-getStoryPropsToSave-wp-story-editor.js 147 kB -23 B (0%)
assets/js/vendors-chunk-html-to-image.js 4.59 kB 0 B
assets/js/vendors-chunk-react-calendar.js 12 kB 0 B
assets/js/vendors-chunk-react-color.js 43 kB 0 B
assets/js/vendors-chunk-web-animations-js.js 14.6 kB 0 B
assets/js/vendors-wp-dashboard.js 151 kB +2 B (0%)
assets/js/web-stories-activation-notice.js 23 kB 0 B
assets/js/web-stories-block.js 18.6 kB 0 B
assets/js/web-stories-embed.js 492 B 0 B
assets/js/web-stories-widget.js 1.01 kB 0 B
assets/js/wp-dashboard.js 120 kB +20 B (0%)

compressed-size-action

@googleforcreators-bot
Copy link
Collaborator

googleforcreators-bot commented Feb 8, 2022

Plugin builds for bb77371 are ready 🛎️!

scoper.inc.php Outdated Show resolved Hide resolved
@timarney timarney self-assigned this Feb 9, 2022
@calvinalkan
Copy link

Hey, I just noticed today that we misspelled the package name. Since I released it on packagist about 4 days or so I still decided to fix it.

So the correct name is: sniccowp/php-scoper-wordpress-excludes. I'm sorry for the inconvenience.

update scoper.inc.php

use json file

add exclude-functions

add exclude classes

add constants

update to new package name + remove util function
@swissspidy swissspidy merged commit 261f7ee into main Feb 10, 2022
@swissspidy swissspidy deleted the fix/10407 branch February 10, 2022 19:59
@spacedmonkey
Copy link
Contributor

@swissspidy Little confused why this was merged, there were still outstanding questions. #10511 (comment)

@swissspidy
Copy link
Collaborator

I simply missed that comment. Resolved now.

I don't see a need for further action here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Infrastructure Changes impacting testing infrastructure or build tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update PHP-Scoper to v0.16.2
5 participants