Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Video Captions: Update AMP plugin dependency #9217

Closed
swissspidy opened this issue Sep 30, 2021 · 0 comments · Fixed by #9827
Closed

Video Captions: Update AMP plugin dependency #9217

swissspidy opened this issue Sep 30, 2021 · 0 comments · Fixed by #9827
Labels
Dependencies Pull requests that update a dependency file P3 Nice to have Status: Blocked On hold for the time being Type: Infrastructure Changes impacting testing infrastructure or build tooling

Comments

@swissspidy
Copy link
Collaborator

swissspidy commented Sep 30, 2021 •
edited
Loading

Feature Description

The style sanitizer config and the custom patch for the AMP plugin dependency added in #9043 can be removed once we can update to an updated version of the AMP plugin, i.e. 2.1.5 or 2.2.0

Same goes for the addition in \Google\Web_Stories\Integrations\AMP::add_amp_content_sanitizers()

Alternatives Considered

Additional Context
@swissspidy swissspidy added Status: Blocked On hold for the time being Type: Infrastructure Changes impacting testing infrastructure or build tooling Dependencies Pull requests that update a dependency file Pod: WP & Infra labels Sep 30, 2021
@swissspidy swissspidy added the P3 Nice to have label Nov 11, 2021
swissspidy added a commit that referenced this issue Nov 26, 2021
@swissspidy
Update AMP plugin to 2.2.0-alpha (develop branch)
b67b5b5 
Also allows removing the patch for allowing `amp-story-captions`.

Fixes #9217
@swissspidy swissspidy mentioned this issue Nov 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Dependencies Pull requests that update a dependency file P3 Nice to have Status: Blocked On hold for the time being Type: Infrastructure Changes impacting testing infrastructure or build tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

PHP Tests: Test against PHP 8.1 GoogleForCreators/web-stories-wp
1 participant
@swissspidy