Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8.1 Compatibility #8520

Closed
spacedmonkey opened this issue Jul 30, 2021 · 4 comments
Closed

PHP 8.1 Compatibility #8520

spacedmonkey opened this issue Jul 30, 2021 · 4 comments
Labels
P2 Should do soon PHP Pull requests that update PHP code Status: Blocked On hold for the time being Type: Enhancement New feature or improvement of an existing feature Type: Infrastructure Changes impacting testing infrastructure or build tooling

Comments

@spacedmonkey
Copy link
Contributor

Feature Description

PHP 8.1 is coming.

The first generally available (GA) version of PHP 8.1 will be released on 25th of Nov, 2021.

With feature freeze soon.

PHP 8.1 feature-freeze is currently scheduled for 20th of July, 2021.

With any luck, our plugin will just work, but we need to validate, dev envs, CI and plugin functionality.

Alternatives Considered

Additional Context

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance Criteria

Implementation Brief
@spacedmonkey spacedmonkey added Type: Enhancement New feature or improvement of an existing feature Type: Infrastructure Changes impacting testing infrastructure or build tooling PHP Pull requests that update PHP code Pod: WP & Infra labels Jul 30, 2021
@swissspidy swissspidy added P2 Should do soon Status: Blocked On hold for the time being labels Aug 2, 2021
@swissspidy
Copy link
Collaborator

Related: #8607

@swissspidy swissspidy changed the title Add support for PHP 8.1 PHP 8.1 Compatibility Sep 27, 2021
@swissspidy
Copy link
Collaborator

Current status:

So nothing major really. Once the latter two issues are resolved, we should be in very good shape.

@swissspidy swissspidy mentioned this issue Sep 27, 2021
Merged
@swissspidy swissspidy mentioned this issue Nov 26, 2021
Merged
@swissspidy
Copy link
Collaborator

I don't think anything is left to be done here.

@swissspidy
Copy link
Collaborator

Unfortunately the Requests upgrade in core was reverted, so there are tons of deprecation warnings again until at least WordPress 6.0

https://github.com/google/web-stories-wp/runs/4449009574?check_suite_focus=true

@swissspidy swissspidy mentioned this issue Aug 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2 Should do soon PHP Pull requests that update PHP code Status: Blocked On hold for the time being Type: Enhancement New feature or improvement of an existing feature Type: Infrastructure Changes impacting testing infrastructure or build tooling
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@spacedmonkey @swissspidy