Leverage PHP 7 language features

[swissspidy]

Task Description

With the PHP version requirement bump we can use language features introduced in PHP 7, like scalar type declarations, return type declarations, and the null coalescing operator.

See https://www.php.net/manual/en/migration70.new-features.php for a full list of changes.

I expect the IDE can help with a lot of these optimizations.

[spacedmonkey]

Useful features.

• Scalar type declarations
• Return type declarations
• Group use declarations

[swissspidy]

PHPStorm gives me tons of recommendations for automatically adding types and using null coalescing operators throughout the code base. That seems like a good start. Don't think grouping use statements provides much value, so we can skip that for now.

We have to be careful adding type declarations to add_action/add_filter callbacks, as it's not guaranteed that we get the expected type.

[spacedmonkey]

PHPStorm gives me tons of recommendations for automatically adding types and using null coalescing operators throughout the code base

How do you see these recommendations?

[swissspidy]

I think the ones I get are provided by the https://plugins.jetbrains.com/plugin/7622-php-inspections-ea-extended- plugin. Can highly recommend installing it 👍

[spacedmonkey]

This might be useful as well - https://github.com/rectorphp/rector

[spacedmonkey]

After trying out refactor, here is the output.

55d3a46

[swissspidy]

Looks promising 👍

We'll probably have to remove some of those for add_filter/add_action callbacks as mentioned above.
Also, we can add return type declarations.