Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump PHP requirement in plugin #7596

Closed
swissspidy opened this issue May 19, 2021 · 3 comments · Fixed by #7949
Closed

Bump PHP requirement in plugin #7596

swissspidy opened this issue May 19, 2021 · 3 comments · Fixed by #7949
Assignees
Labels
P2 Should do soon Type: Infrastructure Changes impacting testing infrastructure or build tooling

Comments

@swissspidy
Copy link
Collaborator

Task Description

Need to bump the PHP 5.6 requirement in two places:

https://github.com/google/web-stories-wp/blob/c4b2f02b98713b17962f283a5f2205f93d56fbce/web-stories.php#L17

https://github.com/google/web-stories-wp/blob/c4b2f02b98713b17962f283a5f2205f93d56fbce/web-stories.php#L50

@swissspidy swissspidy added P2 Should do soon Type: Infrastructure Changes impacting testing infrastructure or build tooling Pod: WP & Infra labels May 19, 2021
@spacedmonkey
Copy link
Contributor

There is also

Remove from unit tests.

https://github.com/google/web-stories-wp/blob/c4b2f02b98713b17962f283a5f2205f93d56fbce/.github/workflows/tests-unit-php.yml#L48

https://github.com/google/web-stories-wp/blob/c4b2f02b98713b17962f283a5f2205f93d56fbce/.github/workflows/tests-unit-php.yml#L56

Remove it from composer

https://github.com/google/web-stories-wp/blob/c4b2f02b98713b17962f283a5f2205f93d56fbce/composer.json#L43

By changing this value in composer.json, we should also build the composer lock file and see what dependencies we can remove / update.

Update coding standards.

On a similar note we can also change this line

https://github.com/google/web-stories-wp/blob/c4b2f02b98713b17962f283a5f2205f93d56fbce/phpcs.xml.dist#L61-L62

We can then review what languages, like Scalar type declarations, Return type declarations and Group use declarations we would want to use. This is an epic in it's self.

@swissspidy
Copy link
Collaborator Author

Yup! I split these all up into different tickets, and turned #7551 into an epic.

Remove from unit tests.

#7599

Remove it from composer

#7594

Update coding standards.

#7595

We can then review what languages, like Scalar type declarations, Return type declarations and Group use declarations we would want to use. This is an epic in it's self.

#7597

@swissspidy
Copy link
Collaborator Author

Note: Do not merge before 1.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Should do soon Type: Infrastructure Changes impacting testing infrastructure or build tooling
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants