feat: Optimized fs walker and util.IsEmptyDir #9433
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
util.IsEmptyDir
was before!info.IsDir()
, though there is no reason to make IO operation to check is the directory empty if it's not a directory.User facing changes
before - It makes N extra IO operations, where N - is docker context files count
after - It doesn't make extra IO operations.
p.s. this changes optimized fs walker by 50% on my laptop