-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Skaffold post renderer #9203
feat: Skaffold post renderer #9203
Conversation
a677f5f
to
220351b
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #9203 +/- ##
==========================================
- Coverage 70.48% 63.63% -6.85%
==========================================
Files 515 632 +117
Lines 23150 32601 +9451
==========================================
+ Hits 16317 20747 +4430
- Misses 5776 10257 +4481
- Partials 1057 1597 +540 ☔ View full report in Codecov by Sentry. |
91f6944
to
5c85f0f
Compare
19d7bf1
to
9bba851
Compare
integration/render_test.go
Outdated
kind: Pod | ||
metadata: | ||
labels: | ||
app1: after-change-1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand correctly, I think this should be app1: before-change-1
? 🤔 Looks like the test reports it passed due to something related with the string with multiple yaml documents and the yaml.Unmarshal
function (used in CheckDeepEqual
); according with the docs yaml.Unmarshal
takes only the first document in the string...I think 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahhh , great catch ! fixed the test and changed the testing helper as well.
Fixes: #9038
Description
skaffold render > somefile.txt