Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add detailed information on how to use helm rendering with v2.X.Y as well as how post-renderer usage works #8093

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

aaron-prindle
Copy link
Contributor

fixes #8057

@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Merging #8093 (72ed50c) into main (290280e) will decrease coverage by 3.99%.
The diff coverage is 53.61%.

❗ Current head 72ed50c differs from pull request most recent head 9bef416. Consider uploading reports for the commit 9bef416 to get more accurate results

@@            Coverage Diff             @@
##             main    #8093      +/-   ##
==========================================
- Coverage   70.48%   66.49%   -4.00%     
==========================================
  Files         515      597      +82     
  Lines       23150    29174    +6024     
==========================================
+ Hits        16317    19398    +3081     
- Misses       5776     8337    +2561     
- Partials     1057     1439     +382     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/test.go 44.44% <0.00%> (ø)
cmd/skaffold/app/exitcode.go 100.00% <ø> (+6.66%) ⬆️
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go 62.50% <14.28%> (-1.14%) ⬇️
cmd/skaffold/app/cmd/render.go 35.48% <18.18%> (-5.90%) ⬇️
cmd/skaffold/app/cmd/lsp.go 28.12% <28.12%> (ø)
cmd/skaffold/app/cmd/run.go 64.28% <33.33%> (-9.63%) ⬇️
cmd/skaffold/app/cmd/fix.go 56.41% <37.50%> (-20.07%) ⬇️
... and 394 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@container-tools-bot
Copy link

Error creating deployment docs-controller-deployment-8093, please visit https://storage.googleapis.com/webhook-logs/logs-8093-1668483664690554135 to view logs.

@container-tools-bot container-tools-bot removed the docs-modifications-v2 runs the docs v2 preview service on the given PR label Nov 15, 2022
Copy link
Contributor

@gsquared94 gsquared94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

docs-v2/content/en/docs/pipeline-stages/deployers/helm.md Outdated Show resolved Hide resolved
Comment on lines 210 to 212
registry: gcr.io/my-project/my-image
repository: gcr.io/my-project/my-image
tag: gcr.io/my-project/my-image

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How to specify for multiple images?

Copy link
Contributor Author

@aaron-prindle aaron-prindle Nov 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this feedback, I have made each example here have multiple images to make this clearer for users. Below is a snippet for the specific yaml you highlighted used with multiple images

values.yaml

image:
  registry: gcr.io
  repository: other-project/other-image
  tag: latest
image2:
  registry: gcr.io
  repository: other-project/other-image
  tag: latest

skaffold.yaml

build:
  artifacts:
    - image: my-image # must match in setValues
    - image: my-image-2 # must match in setValues
deploy:
  helm:
    releases:
      - name: my-chart
        chartPath: helm
        setValues:
          image.registry: my-image
          image.repository: my-image
          image.tag: my-image
          image2.registry: my-image-2
          image2.repository: my-image-2
          image2.tag: my-image-2

@aaron-prindle aaron-prindle force-pushed the fix-8057 branch 5 times, most recently from 0789a66 to 6cd1d87 Compare November 15, 2022 21:19
@aaron-prindle aaron-prindle merged commit 025a882 into GoogleContainerTools:main Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update v2 Helm documentation to better explain artifactsOverrides alternatives and how it works
4 participants