-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add detailed information on how to use helm rendering with v2.X.Y as well as how post-renderer usage works #8093
docs: add detailed information on how to use helm rendering with v2.X.Y as well as how post-renderer usage works #8093
Conversation
e4f468e
to
151d253
Compare
Codecov Report
@@ Coverage Diff @@
## main #8093 +/- ##
==========================================
- Coverage 70.48% 66.49% -4.00%
==========================================
Files 515 597 +82
Lines 23150 29174 +6024
==========================================
+ Hits 16317 19398 +3081
- Misses 5776 8337 +2561
- Partials 1057 1439 +382
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Error creating deployment docs-controller-deployment-8093, please visit https://storage.googleapis.com/webhook-logs/logs-8093-1668483664690554135 to view logs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
registry: gcr.io/my-project/my-image | ||
repository: gcr.io/my-project/my-image | ||
tag: gcr.io/my-project/my-image |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How to specify for multiple images?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this feedback, I have made each example here have multiple images to make this clearer for users. Below is a snippet for the specific yaml you highlighted used with multiple images
values.yaml
image:
registry: gcr.io
repository: other-project/other-image
tag: latest
image2:
registry: gcr.io
repository: other-project/other-image
tag: latest
skaffold.yaml
build:
artifacts:
- image: my-image # must match in setValues
- image: my-image-2 # must match in setValues
deploy:
helm:
releases:
- name: my-chart
chartPath: helm
setValues:
image.registry: my-image
image.repository: my-image
image.tag: my-image
image2.registry: my-image-2
image2.repository: my-image-2
image2.tag: my-image-2
0789a66
to
6cd1d87
Compare
….Y as well as how post-renderer usage works
6cd1d87
to
9bef416
Compare
fixes #8057